Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4275125pxv; Mon, 19 Jul 2021 22:53:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAqeDaqHWj9NLYaCARnVhBaUp3ixinmpvDxSoVH2A3KS+ff/g47pknoANzt/s/pi/q9ul3 X-Received: by 2002:a17:906:4098:: with SMTP id u24mr30774923ejj.462.1626760420500; Mon, 19 Jul 2021 22:53:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626760420; cv=none; d=google.com; s=arc-20160816; b=ElbUAnFX1+V4UaGz0iOCOBAVqxX5ofcJZVDi1kGH8iJtpylNN+4hqwz+o4SSZPqBaK KW+BdK9TIp1oJGXN2WkvfpRTpc22LvRxU9GQ40TNk6RVlSmGQdkTwtGRQP7m9MMLKS5i 9CIwUitk+KtXwI7PIykUO0VHfopss+PBINdiUco/eZXAgXFHO07iVxTmn0WA13x3MNKY fYB5rD8rJQeOPS4/qP6YDOxCJLk6XCWbJ51DN8QpSfH4w2zFUSFV8TbO0tShbW/q8MQU Cmw1ZT9GTuE5ZQsMVPC4lQcZONiMZKQ9I4SL3uwEvbnemg2vBj7ApkSjO+B9IbISYAlv O6ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=GuZGu709relhTU8MWXOrKH/scpDYO+Qejn1MeBjtEAI=; b=bVbaY7wuNBSEDq0Fy8AVbe+mkpkj3cHaOgRFFsc/7KVE1Ju+Pr5KxaOEteI3h6NY3l WaUCl+jyaDq89pQhl1E7d8asFzUucocPFLRI0JqtLW2sFT6i3Hu95dcR1QnIIiNVZI2a jLVc0ZDewnDDobHl1z/OrZfxIhkuO5tkvLa0sICsECE2szi8HfGoLGLQXyqBbdMuVqZW f8HyDa+smsGsPgnWYzXGCe9aJU4f9zjXFeURCrS6tW22HCgmW8uiPDL3Mt795VXXxebX L3Q9CfYB1pp+N2S1flmC9ujphUFm/uKJpDMVJ78nSie2/ZB4QSyj/BQ1Z2WGtjxRFisj YEAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z15si22831426edc.64.2021.07.19.22.53.17; Mon, 19 Jul 2021 22:53:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236550AbhGTFLL (ORCPT + 99 others); Tue, 20 Jul 2021 01:11:11 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:53838 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S236413AbhGTFKw (ORCPT ); Tue, 20 Jul 2021 01:10:52 -0400 X-UUID: 602f117abfb342b0b1afcd043fe3ba5a-20210720 X-UUID: 602f117abfb342b0b1afcd043fe3ba5a-20210720 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1274704372; Tue, 20 Jul 2021 13:51:22 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 20 Jul 2021 13:51:20 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 20 Jul 2021 13:51:20 +0800 From: Yongqiang Niu To: Chun-Kuang Hu CC: Rob Herring , Matthias Brugger , Philipp Zabel , David Airlie , Daniel Vetter , Jassi Brar , Yongqiang Niu , Fabien Parent , Dennis YC Hsieh , , , , , , , Hsin-Yi Wang Subject: [PATCH v3] Fixes: a6b7c98afdca(drm/mediatek: add mtk_dither_set_common() function) Date: Tue, 20 Jul 2021 13:51:17 +0800 Message-ID: <1626760277-5733-2-git-send-email-yongqiang.niu@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty In-Reply-To: <1626760277-5733-1-git-send-email-yongqiang.niu@mediatek.com> References: <1626760277-5733-1-git-send-email-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dither 6 setting is missed in a6b7c98afdca bit 1 is lfsr_en( "Enables LFSR-type dithering"), need enable bit 2 is rdither_en(Enables running order dithering), need disable Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 99cbf44..7dd8e05 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -26,6 +26,7 @@ #define DISP_OD_CFG 0x0020 #define DISP_OD_SIZE 0x0030 #define DISP_DITHER_5 0x0114 +#define DISP_DITHER_6 0x0118 #define DISP_DITHER_7 0x011c #define DISP_DITHER_15 0x013c #define DISP_DITHER_16 0x0140 @@ -135,6 +136,7 @@ void mtk_dither_set_common(void __iomem *regs, struct cmdq_client_reg *cmdq_reg, if (bpc >= MTK_MIN_BPC) { mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_DITHER_5); + mtk_ddp_write(cmdq_pkt, 0x3002, cmdq_reg, regs, DISP_DITHER_6); mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_DITHER_7); mtk_ddp_write(cmdq_pkt, DITHER_LSB_ERR_SHIFT_R(MTK_MAX_BPC - bpc) | -- 1.8.1.1.dirty