Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4295631pxv; Mon, 19 Jul 2021 23:34:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwZ1cE52sdwRZSbpskOhbzJfIMUe0f15ohBfl88u1M8Y6wpEtq4wzPWtyQln9G9f2PwkJ2 X-Received: by 2002:a05:6402:30af:: with SMTP id df15mr39581536edb.19.1626762863313; Mon, 19 Jul 2021 23:34:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626762863; cv=none; d=google.com; s=arc-20160816; b=0EujGhEP9lEifjvQl6KPTl5EMHxRrKdDUrfGZUcHSotGVRL1rYpWGDeJZMyYi/ddSR x5dcbjUB84e/O8YZHWJWvRpWlWnmsQTAz4t11hDvqufas5PkQqcqV2qI+AmuzaoZvZL7 AFwCDDB+CrD4tRWZ0tJXffIcf6eLlQ+kWlPZF2YPboXeR8VPAd/Znxy4MN7O9QIPoM54 6rl/eqWfKnsEhl1R/rDFjkXxOGfwuItownyq0/EYSn+bhaL32NB6f6KXpbgDEdTlSeh4 e8f+29k+I+v3Esy2bP3l1Wjfnxk0lyK6NCdoe8Hg6AgypG10wrk/P0EhuR6/j3q+2W8K aW5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=2UEQX1fl0o3lRU3IfC7GyAvLVPRkxv0G4A84duZUZOM=; b=rTYVTA15T214YS+VAr6W8WTFjsfA3M4pF6vBU9fU/2JSB+Ca9iZ1d6814zk0WFwUeQ pTm0PhopHz2m2qEItc4rV+xj8muU7g349OM6/7wZ/6laKKuqRUXZiwhPSbJSs1Hy5cOl JRBGb6bLRi8lLIv3ytZlY/y/l6A+lPYG3xipNn/PfG1YWc24VvLoAIxsBb4ykOE/YfLi JuIMaCwgdIJtVbXY7lwjN6s3g/BA+ZWGTiJ/ubAr1QTr0e548hJTdgY+lMGivDwz4t23 9izZq9rJBoE1bi8fStTzap8Kf7k1Bt785P71utnc105Qr4sPXSjKPWz8KjTIFrpdrazA Sjcg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mj21si22860203ejb.25.2021.07.19.23.33.59; Mon, 19 Jul 2021 23:34:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238779AbhGTFt4 (ORCPT + 99 others); Tue, 20 Jul 2021 01:49:56 -0400 Received: from mailgw01.mediatek.com ([60.244.123.138]:60502 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S239463AbhGTFta (ORCPT ); Tue, 20 Jul 2021 01:49:30 -0400 X-UUID: 2eaf68b87a3740a5aa849ebacb48b40c-20210720 X-UUID: 2eaf68b87a3740a5aa849ebacb48b40c-20210720 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 917718323; Tue, 20 Jul 2021 14:29:58 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 20 Jul 2021 14:29:52 +0800 Received: from localhost.localdomain (10.17.3.153) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 20 Jul 2021 14:29:51 +0800 From: Yongqiang Niu To: Chun-Kuang Hu CC: Rob Herring , Matthias Brugger , Philipp Zabel , David Airlie , Daniel Vetter , Jassi Brar , Yongqiang Niu , Fabien Parent , Dennis YC Hsieh , , , , , , , Hsin-Yi Wang Subject: [PATCH v5] drm/mediatek: add dither 6 setting Date: Tue, 20 Jul 2021 14:29:48 +0800 Message-ID: <1626762588-6020-2-git-send-email-yongqiang.niu@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty In-Reply-To: <1626762588-6020-1-git-send-email-yongqiang.niu@mediatek.com> References: <1626762588-6020-1-git-send-email-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dither 6 setting is missed in a6b7c98afdca bit 1 is lfsr_en( "Enables LFSR-type dithering"), need enable bit 2 is rdither_en(Enables running order dithering), need disable Fixes: a6b7c98afdca(drm/mediatek: add mtk_dither_set_common()) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 99cbf44..7dd8e05 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -26,6 +26,7 @@ #define DISP_OD_CFG 0x0020 #define DISP_OD_SIZE 0x0030 #define DISP_DITHER_5 0x0114 +#define DISP_DITHER_6 0x0118 #define DISP_DITHER_7 0x011c #define DISP_DITHER_15 0x013c #define DISP_DITHER_16 0x0140 @@ -135,6 +136,7 @@ void mtk_dither_set_common(void __iomem *regs, struct cmdq_client_reg *cmdq_reg, if (bpc >= MTK_MIN_BPC) { mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_DITHER_5); + mtk_ddp_write(cmdq_pkt, 0x3002, cmdq_reg, regs, DISP_DITHER_6); mtk_ddp_write(cmdq_pkt, 0, cmdq_reg, regs, DISP_DITHER_7); mtk_ddp_write(cmdq_pkt, DITHER_LSB_ERR_SHIFT_R(MTK_MAX_BPC - bpc) | -- 1.8.1.1.dirty