Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Date:   Tue, 20 Jul 2021 10:14:35 +0300
From:   Eli Cohen <elic@nvidia.com>
To:     Stefano Garzarella <sgarzare@redhat.com>
CC:     <mst@redhat.com>, <jasowang@redhat.com>,
        <virtualization@lists.linux-foundation.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] vdpa/vdpa_sim: Use the negotiated features when
 calling vringh_init_iotlb
Message-ID: <20210720071435.GA4647@mtl-vdi-166.wap.labs.mlnx>
References: <20210720052533.415991-1-elic@nvidia.com>
 <20210720065740.56udn3ndebzvu26o@steredhat>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20210720065740.56udn3ndebzvu26o@steredhat>
User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 07:14:40.4077
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ba0c638e-f697-4b45-5b54-08d94b4e0a7f
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT041.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3920
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 20, 2021 at 08:57:40AM +0200, Stefano Garzarella wrote:
> On Tue, Jul 20, 2021 at 08:25:33AM +0300, Eli Cohen wrote:
> > When calling vringh_init_iotlb(), use the negotiated features which
> > might be different than the supported features.
> > 
> > Fixes: 2c53d0f64c06f ("vdpasim: vDPA device simulator")
> > Signed-off-by: Eli Cohen <elic@nvidia.com>
> > ---
> > v0 --> v1:
> > Update "Fixes" line
> > 
> > drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> > index 14e024de5cbf..89a474c7a096 100644
> > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
> > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> > @@ -66,7 +66,7 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx)
> > {
> > 	struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx];
> > 
> > -	vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features,
> > +	vringh_init_iotlb(&vq->vring, vdpasim->features,
> > 			  VDPASIM_QUEUE_MAX, false,
> > 			  (struct vring_desc *)(uintptr_t)vq->desc_addr,
> > 			  (struct vring_avail *)
> > @@ -86,7 +86,7 @@ static void vdpasim_vq_reset(struct vdpasim *vdpasim,
> > 	vq->device_addr = 0;
> > 	vq->cb = NULL;
> > 	vq->private = NULL;
> > -	vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features,
> > +	vringh_init_iotlb(&vq->vring, vdpasim->features,
> 
> vdpasim_vq_reset() is called while resetting the device in vdpasim_reset()
> where we also set `vdpasim->features = 0` after resetting the vqs, so maybe
> it's better to use the supported features here, since the negotiated ones
> are related to the previous instance.
> 

I don't think using supported features is valid. Better to make sure
vringh_init_iotlb() is called after the features have been negotiated.

> Thanks,
> Stefano
>