Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4334605pxv; Tue, 20 Jul 2021 00:53:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzx9IFYRFO9agF9U+2CP+Zc5+E9aCB9vEVJ0JU82sUzxbAlUD+lnN7Ml87fZbY4n/lVBD4C X-Received: by 2002:a17:906:a450:: with SMTP id cb16mr27109255ejb.296.1626767638307; Tue, 20 Jul 2021 00:53:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626767638; cv=none; d=google.com; s=arc-20160816; b=A6eY4Ydo1bv32RO0kJK0Ny3J9WAsInVQoF17ibwAPotZXS3v2a/s9CLxbB7SaMWGjm E3WRB3T6Rgp6oqMt57dR7HNNumSfyZIGf5vBMAIiNnLZE6M2f2oMMPQ41rOcXYplIR4R oKZ9GExYMb/UGzZXOdIRHdwPKIhCARcwxntrjnaqHXMfI1ewTF6peo4I5W+FAcNo0JJo D4IEDdZ3tcizXIVh/GgBAj7DKXhOt6qjdmGFFe09376rKLwdWkERuGQaUqKKpikNeifA lVhG2cQRLQUCVD6X9evwi1lOkkwhhBDCsNMBvoqMUOhIbUM7O4V0D3STVaB8O6KDbS0G 87Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=XPjO/khXFaQcpR37/xHIhTW31Pd1vCNQKS/EoiRi0cQ=; b=F3ym9pewjyjyKAN/ygu9sbMlXNKz8VgSpQk7muJ7/noVqkj/32d/NmE3UIduKm63F7 cU24l5AfJTKvaE2fOw85/R+7q3jvwdZS3kP6/QOrpz2QnImX1PCMfTgBtuF8RhkdnsBh be9kvo0WhlKtG8TEzw3BQxvyydlQLuJjEdThGFjZBGft+lju+c0oXT8B0jG3Y8+2SJt8 2/c+ZlLeEgNwx+C78SZchARBIe2k84H7gW4eElWaZmT7SHpvmiZv/dB7I7SEfKSK3QsS oE97YPbnYH9olTpd869/aU2w+20EKMgrXpGSof6qSfshs4O/m0uO6lvU3oFgIFlKlsD5 bisw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v11si22900127ejb.688.2021.07.20.00.53.34; Tue, 20 Jul 2021 00:53:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231345AbhGTHLV (ORCPT + 99 others); Tue, 20 Jul 2021 03:11:21 -0400 Received: from verein.lst.de ([213.95.11.211]:54106 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229825AbhGTHJu (ORCPT ); Tue, 20 Jul 2021 03:09:50 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 638E16736F; Tue, 20 Jul 2021 09:50:25 +0200 (CEST) Date: Tue, 20 Jul 2021 09:50:25 +0200 From: Christoph Hellwig To: Ming Lei Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH V2] genirq/affinity: add helper of irq_affinity_calc_sets Message-ID: <20210720075025.GA17565@lst.de> References: <20210720044209.851141-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720044209.851141-1-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +int irq_affinity_calc_sets(unsigned int affvecs, struct irq_affinity *affd) > +{ > + /* > + * Simple invocations do not provide a calc_sets() callback. Call > + * the generic one. > + */ > + if (!affd->calc_sets) > + default_calc_sets(affd, affvecs); > + else > + affd->calc_sets(affd, affvecs); Nit: avoid pointless negations: if (affd->calc_sets) affd->calc_sets(affd, affvecs); else default_calc_sets(affd, affvecs); Otherwise looks good: Reviewed-by: Christoph Hellwig