Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4387963pxv; Tue, 20 Jul 2021 02:36:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpSFZEjIuFWNW+IWlizNWwuXpBS8tcAMhJkkGTMebYO1nW5c1S9mw7uOQFNyVAEtH07q6P X-Received: by 2002:a17:906:7629:: with SMTP id c9mr1066858ejn.527.1626773812957; Tue, 20 Jul 2021 02:36:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626773812; cv=none; d=google.com; s=arc-20160816; b=NC9j2Jc4WfwjtGQ9Msh8IerS0Rtu2nPXUjcA1CF7tiNYDJN4PDJB8FT/VkyOgMaHtH 5CGEXNx9s2txu74/Zy8wiCyPR4q++Sxa5mxRsG2KfMbKXZaBo+3nDuN6Dqq0sX4tJc8U TwMxhss8tCa1Fj1oDCpjxEEp+xYVzXu5YgwggDZtcIEtLF7MTgii/9QQnAkkp/X9HUrs jap0G9rENk7gsXA1VmdbBA85m+s3eMwoo6vOwLVBkwKCR6qTp5ckiNQZbw92LVK+3NMc rYRPglFMEYIv4b86Ylct2LNfEydSLn12ajbPckDp13+2M0RgrNq08A3DGTetGDsf5EhG aIMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=rgdnRd+t5Fn08CGE5HYFeKJTBlBO+nXJPRDAHBMbx7U=; b=HFfFP3f9POEwA60mdrCMvGpoeu6P9f1UrB0f0mgWMrVokh6d+/Jrd3SB5tet5V4+Be 3a7RQ2jCE1HV8BjPc8ZfNpIPdSckAit0fBkPaCPS6WL7oPpld939CJU0AHuov9K1TwT2 /fPvCKjZZwgR9NzcorEGMMAoI6tXR2a6ja2pvTDFBRSjK1RtHD2UXLh9bI+yLLu/jSaw Q+JVcobvf0qEA57zNxj1eX6K7Co+4oBU79bOnJi8s2igsNd7f3D9VR3/sAWgH+OHf4vD pCYcB9bQ+RwAzRrB6z8elkEpB0aX3ecxWLy4jjm3uCrWSJcrmWYD6GusHJOSLqG18xdY 0aaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mp36si25348833ejc.478.2021.07.20.02.36.29; Tue, 20 Jul 2021 02:36:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234703AbhGTIvw (ORCPT + 99 others); Tue, 20 Jul 2021 04:51:52 -0400 Received: from mail-ua1-f51.google.com ([209.85.222.51]:40945 "EHLO mail-ua1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235161AbhGTIvb (ORCPT ); Tue, 20 Jul 2021 04:51:31 -0400 Received: by mail-ua1-f51.google.com with SMTP id r9so7849779ual.7 for ; Tue, 20 Jul 2021 02:32:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rgdnRd+t5Fn08CGE5HYFeKJTBlBO+nXJPRDAHBMbx7U=; b=PprMUETTp7Ip8ixzzlQchgNDtkVmvoB8WIF3lqE5n8kdj8j8scuwJ8PEkfvBnTajCt 5UsaHQ7Ct3hwv8mBETZEunStM9/r90p6gTXn7WZRgiGjhnQTntbDnfFZUknABhWsaOOU Ba+2Hzyje8wbUXLUuTZmNj+2CayCZUDEEQBGYy6IneHcl38JDh1SeYDkje4EPZNl2J9X B1nCMPtT49LNy1K73p0+Y1Foqb+XNm0URF1XIFZIupD4J8aIdc+QuwEG9yDIcBNDaG5U z56bcZ5DsXB2gkUKOiWs9arenkka62xI6RoUV8/pabCyYVv82iTKtsN++2BOdX8cUHrp 8dpw== X-Gm-Message-State: AOAM531QoFgXYv+i7z3XwoUkXauggjCI4MYGdaWmOpRnHAFsrFpbnNWU J0YVzs9uUlEqsSLON7NF+ETa9RDU+lCjnD7bvfQ= X-Received: by 2002:ab0:2554:: with SMTP id l20mr30460183uan.58.1626773523243; Tue, 20 Jul 2021 02:32:03 -0700 (PDT) MIME-Version: 1.0 References: <37097718-c472-025a-2058-55667badc5b9@gmail.com> In-Reply-To: <37097718-c472-025a-2058-55667badc5b9@gmail.com> From: Geert Uytterhoeven Date: Tue, 20 Jul 2021 11:31:51 +0200 Message-ID: Subject: Re: [PATCH 0/4] __asm_copy_to-from_user: Fixes To: Akira Tsukamoto Cc: Paul Walmsley , Palmer Dabbelt , Guenter Roeck , Albert Ou , linux-riscv , Linux Kernel Mailing List , "Gabriel L. Somlo" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tsukamoto-san, On Tue, Jul 20, 2021 at 10:49 AM Akira Tsukamoto wrote: > These are series for the fix reported by Guenter, Geert and Qiu. > > One patch to fix overrun memory access, one patch to fix on rv32. > And two more for clean up and typos. > > Have tested on qemu rv32, qemu rv64 and beaglev beta board. > > Thanks for the report and instructions to reproduce the error on rv32. > > Akira > > Akira Tsukamoto (4): > riscv: __asm_copy_to-from_user: Fix: overrun copy > riscv: __asm_copy_to-from_user: Fix: fail on RV32 > riscv: __asm_copy_to-from_user: Remove unnecessary size check > riscv: __asm_copy_to-from_user: Fix: Typos in comments > > arch/riscv/lib/uaccess.S | 27 +++++++++++++-------------- > 1 file changed, 13 insertions(+), 14 deletions(-) Thanks, RV32 (vexriscv) is booting fine again. Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds