Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4391359pxv; Tue, 20 Jul 2021 02:42:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyanMwVJydnW5CvXNpEBEbqebQv3yYoIx8hyDkubUmC2KPkwyPjqQcB8ZMsA+1yYEcuv2Yr X-Received: by 2002:a02:c8d0:: with SMTP id q16mr25848123jao.110.1626774158274; Tue, 20 Jul 2021 02:42:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626774158; cv=none; d=google.com; s=arc-20160816; b=QYKbI8ynkcbqDoF0BRCMTIIzznEJvkzafmD/sfkqL4y+FH9JnxJanOtgfKb/I9ZvBp jMfgyRDeMWYlvzdbvejkG18jT/pMzvhauLORM4yDh8d9BxHIoP5xg1BI17p362/LbH14 59PXN4KmwF0XsN+QklRrZYF4eBpR0n8HLPWULHxeUH1UOhNVdu58Ii1VgvfaAOtYAwOl nzFB82Aikr657y85JPqjdDbX9Y1y9zE3ohg+vL4GLbG4kt8G11i4f/fBocE+LostoXg7 qLk5RyN57bsDhWJg7bAAIDkpqeVxv3fjkUju64RctWCDR1KZHundnbhp17YVnBS4XU8u DV1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=7y2Yp4KzVA+dJDohMcmoFCcrUAOrpun8rviBC7D3RSE=; b=ey+pjd796OV0EIUYUCn/ZQifmfGapHdSAEk8Ppyb5n6PBrDj/cSifdeDE2QE3Jaz31 BFWajioXW0cYyCd1sFYGflOQpy98+l9dkswxPfHllGlMvWGGSWvmkLuK540q0240TkeG 2mdZJtg0BoqpCUgbzqYeFIqeg9MURjmMEG66C8WV5TTB5pF6oY5rEWEEmfYmjZS2931/ t7tWfHNV3KeuRvNTd+JadBfGEcio0kZ5Bq/HFQMPOEr12ZRPYx9E/2zgnGLUE3vD/dlJ v7gIKHtnsOn5X0Jb2kSfH3nA5pMXbGt629RDt8GD5UMnsg57IaEKye14SpzldsBF2OaU Je4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q17si23924749ilm.115.2021.07.20.02.42.26; Tue, 20 Jul 2021 02:42:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231560AbhGTI7C (ORCPT + 99 others); Tue, 20 Jul 2021 04:59:02 -0400 Received: from outbound-smtp49.blacknight.com ([46.22.136.233]:41981 "EHLO outbound-smtp49.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbhGTI7B (ORCPT ); Tue, 20 Jul 2021 04:59:01 -0400 Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp49.blacknight.com (Postfix) with ESMTPS id 0B060FB580 for ; Tue, 20 Jul 2021 10:39:39 +0100 (IST) Received: (qmail 29527 invoked from network); 20 Jul 2021 09:39:38 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.255]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 20 Jul 2021 09:39:38 -0000 Date: Tue, 20 Jul 2021 10:39:37 +0100 From: Mel Gorman To: Muchun Song Cc: akpm@linux-foundation.org, shy828301@gmail.com, cuibixuan@huawei.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: mmap_lock: fix disabling preemption directly Message-ID: <20210720093937.GV3809@techsingularity.net> References: <20210720074228.76342-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210720074228.76342-1-songmuchun@bytedance.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 20, 2021 at 03:42:28PM +0800, Muchun Song wrote: > The commit 832b50725373 ("mm: mmap_lock: use local locks instead of > disabling preemption") fix a bug by using local locks. But commit > d01079f3d0c0 ("mm/mmap_lock: remove dead code for !CONFIG_TRACING > configurations") changes those lines to original version. I guess > it is introduced by the conflicts fixing on merging. > > Fixes: d01079f3d0c0 ("mm/mmap_lock: remove dead code for !CONFIG_TRACING configurations") > Signed-off-by: Muchun Song Acked-by: Mel Gorman -- Mel Gorman SUSE Labs