Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 20 Jul 2021 17:48:22 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Greg KH <gregkh@linuxfoundation.org>,
        Kelvin Cheung <keguang.zhang@gmail.com>
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5] dmaengine: Loongson1: Add Loongson1 dmaengine driver
Message-ID: <YPa/DsO1vWcXKJKd@matsya>
References: <20210704153314.6995-1-keguang.zhang@gmail.com>
 <YO5yo8v/tRZLGEdo@matsya>
 <CAJhJPsUNCSK4VYv9Z4ZNDxC03F4CxQoAXCCf+TJmmbdUe4XNNA@mail.gmail.com>
 <YPLrsXEmmHPtbZ+N@matsya>
 <YPMVyYoBojHYsMbJ@kroah.com>
 <YPa2+TsdL0PrR3hR@matsya>
 <YPa4IAk3sh7bai15@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YPa4IAk3sh7bai15@kroah.com>
Precedence: bulk

On 20-07-21, 13:48, Greg KH wrote:
> On Tue, Jul 20, 2021 at 05:13:53PM +0530, Vinod Koul wrote:
> > On 17-07-21, 19:39, Greg KH wrote:
> > > On Sat, Jul 17, 2021 at 08:09:45PM +0530, Vinod Koul wrote:
> > > > On 17-07-21, 18:57, Kelvin Cheung wrote:
> > > > > Vinod Koul <vkoul@kernel.org> 于2021年7月14日周三 下午1:14写道：
> > > > > >
> > > > > > On 04-07-21, 23:33, Keguang Zhang wrote:
> > > > > >
> > > > > > > +static struct platform_driver ls1x_dma_driver = {
> > > > > > > +     .probe  = ls1x_dma_probe,
> > > > > > > +     .remove = ls1x_dma_remove,
> > > > > > > +     .driver = {
> > > > > > > +             .name   = "ls1x-dma",
> > > > > > > +     },
> > > > > > > +};
> > > > > > > +
> > > > > > > +module_platform_driver(ls1x_dma_driver);
> > > > > >
> > > > > > so my comment was left unanswered, who creates this device!
> > > > > 
> > > > > Sorry!
> > > > > This patch will create the device: https://patchwork.kernel.org/patch/12281691
> > > > 
> > > > Greg, looks like the above patch creates platform devices in mips, is
> > > > that the right way..?
> > > 
> > > I do not understand, what exactly is the question?
> > 
> > So this patch was adding Loongson1 dmaengine driver which is a platform
> > device. I asked about the platform device and was told that [1] creates
> > the platform device. I am not sure if that is the recommended way given
> > that you have been asking people to not use platform devices.
> 
> Yes, but this link:
> 
> > [1]: https://patchwork.kernel.org/patch/12281691
> 
> Does look like a "real" platform device in that you have fixed resources
> for the device and no way to discover it on your own.
> 
> But why are you not using DT for this?  That looks like the old platform
> data files.

Apparently I was told that this platform does not use DT :( Looking at
it it should.. Maybe Kelvin can explain why..

-- 
~Vinod