Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 20 Jul 2021 07:34:54 -0600
From:   Rob Herring <robh@kernel.org>
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Yangtao Li <tiny.windzz@gmail.com>, Nishanth Menon <nm@ti.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>, linux-pm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] dt-bindings: opp: Convert to DT schema
Message-ID: <20210720133454.GA4147058@robh.at.kernel.org>
References: <20210719202732.2490287-1-robh@kernel.org>
 <20210720043108.bmoydy3a2r3gqhnq@vireshk-i7>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210720043108.bmoydy3a2r3gqhnq@vireshk-i7>
Precedence: bulk

On Tue, Jul 20, 2021 at 10:01:08AM +0530, Viresh Kumar wrote:
> On 19-07-21, 14:27, Rob Herring wrote:
> > Convert the OPP v1 and v2 bindings to DT schema format. As the OPPv2 binding
> > can be extended by vendors, we need to split the common part out from the
> > "operating-points-v2" conforming compatible.
> > 
> > Cc: Yangtao Li <tiny.windzz@gmail.com>
> > Cc: Nishanth Menon <nm@ti.com>
> > Cc: Stephen Boyd <sboyd@kernel.org>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Chen-Yu Tsai <wens@csie.org>
> > Cc: linux-pm@vger.kernel.org
> > Cc: linux-arm-kernel@lists.infradead.org
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > v2:
> > - move opp-peak-kBps next to opp-avg-kBps. Also add a dependency schema.
> > - Correct the opp-microamp schemas. It's always a single value for each
> >   regulator.
> > - Add missing type for '^opp-microamp-'
> 
> Applied. Thanks.

I found some issues with it, can you drop it? 

Rob