Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4593198pxv; Tue, 20 Jul 2021 07:19:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4evtzVphnVl4h4nqNWBH9fDBjSmVHOm90Y0LbZZXYl79OaBaC62V0OVl4w9ixtl6NZNrM X-Received: by 2002:aa7:d98d:: with SMTP id u13mr41819358eds.238.1626790781205; Tue, 20 Jul 2021 07:19:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626790781; cv=none; d=google.com; s=arc-20160816; b=L+OoE9kDIHKYkC51sI6iw9lP1+veCDYpcg4S/cb6XCM9CtO/ZXWKkYicB3lc/ri1Po q2FXzSXtrTN05UXHnoQhq5FGunrChSAshZB3Hnbmu68Ft4AjHZFtCVcGaCyhoOfLU0re cGThKyBjpjX7y8uRhUY+s2JZdmfrMsAWaOsexUMdJHpBeqUOp80KgdFueBVQeCQ5g+Ly A+51bLHNGgVXUpZl0FspZGyG20b1qWcXJ77dKwoxaEA46/laDLc0+MNRSDZx79GacYan B2VpCYp5czM9so7ihNuvldEMexZb0vfbp2PhxM9gfcSscMfRMYCypAJJHjqAzh6Y/T0O ZouA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=PkAUSa8iO+7WteRWzJzZbVWHxdXWutFxMQnYCPT03FA=; b=XmmE1FUMteC9m5C8YOU7kLPdy+GxTmaZsnUoxH/Vvcjorw+YfTO6SY6iJ+nI5nJrll sqpbwJYUwrw6H6d0d45hPNtZvbaHkxCuG5yOlCF7D0T/7tM6hl5tgz7u7JFnUUu4bx2w 7JW3OtB8B1gKTEVFFY0BExN+M/pyO7Vc69XILNlo6TsRsq6ifVb+GlPQPfnLzU6+4gAR UXZByYgsLtJ+U44MM395LnIDHW0OLUm9YY3K2gMcLqHRE4b3poHUOrC3jXwZ0ir/+yQ9 oaaXVcZj9+O7TKpBMLgl/Er2uuQ3ih9Z+LG5QHGh/Dzj04s+ZsaphGVGB2/C8/goD76E J5mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="CXXbqsq/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm5si25609710edb.564.2021.07.20.07.19.17; Tue, 20 Jul 2021 07:19:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="CXXbqsq/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239685AbhGTNeu (ORCPT + 99 others); Tue, 20 Jul 2021 09:34:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239333AbhGTN2A (ORCPT ); Tue, 20 Jul 2021 09:28:00 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72DB2C061574; Tue, 20 Jul 2021 07:08:13 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id n11so11484423plc.2; Tue, 20 Jul 2021 07:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PkAUSa8iO+7WteRWzJzZbVWHxdXWutFxMQnYCPT03FA=; b=CXXbqsq/+4Uai+DmJMRIR7PpNVY4/MeKGB04RdhVWil0uMU607jC2kcpJbANpSHaGj 32ciUW4H9ieKAG5jczZ0Eu/Ls36kDRJCFsuUhLJzagBoQXak7j/fkyvn7JzrtpNlLGRn QFuBtS/wu/2xbu8OoDoaWx+aKazVvuojOMQOCCimIy3qWAPDXLSNn8rjjt+HX3/80DcZ 0uRP85MisKdG0p2GRorbt5vwoE9DiE1rmYow/FTczt1nWJItWJB61iiLXxguWbPhbBCD 3BcC4Dlwqk2IJTe9Up7Fkon5b+CYG+J1Ukab7utwSZb3kGibyzI91m/05DGdgaYQFMZV IIkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PkAUSa8iO+7WteRWzJzZbVWHxdXWutFxMQnYCPT03FA=; b=t0TQMQLmMcKrCmGFGpdGVXSFQ7CkoGuWNxktltwfiYrMcCGt37PfjqX8nAw2Gzvd7k LmRRSfxK9N9bi5WIaiEfSePbMR8pBuzEizRo38VZrvjRa0I348N2AhGPY846j8xiNZ7S R0g0SaX+NsmMOFDe4v89XR+r36h+sb0uVu+pvZirNLmJIwxuMwS3TZr4g0ew4t80bee7 43vXtLpSzhLAsZXkFanP9a5HyLmNFKFUOOS2NauWGIGUVByhsEgp70dRMAV6KAoUTXiY tQ3SVgmq4pdEH48tERmEMstt2NoYHvFfZnnd0cesFeEgsMUw+GIbubVgcCHCBo8d7LqA jtew== X-Gm-Message-State: AOAM533K/mb5e0HwQTu4Nle/F/ZcZJOXzJj+fhGKZXqYKbop/ozphpnO jtf2S7PKQC8E/l3n0rHcOT251etZxOzq+Hy1pwA= X-Received: by 2002:a17:902:b198:b029:11b:2246:e374 with SMTP id s24-20020a170902b198b029011b2246e374mr23684180plr.17.1626790092873; Tue, 20 Jul 2021 07:08:12 -0700 (PDT) MIME-Version: 1.0 References: <20210716114210.141560-1-antoniu.miclaus@analog.com> In-Reply-To: From: Andy Shevchenko Date: Tue, 20 Jul 2021 17:07:31 +0300 Message-ID: Subject: Re: [PATCH v6 1/2] iio: frequency: adrf6780: add support for ADRF6780 To: "Miclaus, Antoniu" Cc: "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jic23@kernel.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 20, 2021 at 4:17 PM Miclaus, Antoniu wrote: > > From: Andy Shevchenko > > Sent: Friday, July 16, 2021 5:53 PM > > On Fri, Jul 16, 2021 at 2:43 PM Antoniu Miclaus > > wrote: ... > > First question is why not to use the regmap API (I have heard it has > > gained support of 17 bit)? > > Initially that was the plan, but after this patch: > https://github.com/torvalds/linux/commit/4191f19792bf91267835eb090d970e9cd6277a65 > the custom write formats for regmap allow the read only via cached registers. > > Therefore, I preferred using spi transfers for write/read to/from the device. Not sure I follow you. That patch is upstream. Does it prevent you from switching to regmap SPI API? ... > > > + depends on COMMON_CLK > > > > Is it mandatory for any function inside the device? > > Yes. It will serve as LO input to the device. But can the device work without it (with limited functionality)? -- With Best Regards, Andy Shevchenko