Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031210AbWKUQtj (ORCPT ); Tue, 21 Nov 2006 11:49:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1031112AbWKUQtj (ORCPT ); Tue, 21 Nov 2006 11:49:39 -0500 Received: from nlpi043.sbcis.sbc.com ([207.115.36.72]:53387 "EHLO nlpi043.sbcis.sbc.com") by vger.kernel.org with ESMTP id S1031210AbWKUQth (ORCPT ); Tue, 21 Nov 2006 11:49:37 -0500 X-ORBL: [67.117.73.34] Date: Tue, 21 Nov 2006 16:47:25 +0000 From: Tony Lindgren To: Imre Deak , Komal Shah Cc: James Simmons , Vladimir , Pavel Machek , kernel list , Linux Fbdev development list Subject: Re: Siemens sx1: merge framebuffer support Message-ID: <20061121164723.GB8193@atomide.com> References: <20061118181607.GA15275@elf.ucw.cz> <20061120190404.GD4597@atomide.com> <3a5b1be00611210734k79c81305q7b229139c2b17ef6@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a5b1be00611210734k79c81305q7b229139c2b17ef6@mail.gmail.com> User-Agent: Mutt/1.5.12-2006-07-14 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2083 Lines: 58 Hi, * Komal Shah [061121 15:35]: > On 11/21/06, James Simmons wrote: > > > >Can you post the framebufer driver to the framebuffer list. We like to do > >peer review. Thank you :-) It would be nice to get the framebuffer integrated. I think it would be best if Imre submitted the patches as it's mostly his work. Imre, do you have time to send the patches to framebuffer list? If not, I can send them. > >On Tue, 21 Nov 2006, Vladimir wrote: > > > >> 2006/11/20, Tony Lindgren : > >> > * Pavel Machek [061118 18:16]: > >> > > From: Vladimir Ananiev > >> > > > >> > > Framebuffer support for Siemens SX1; this is second big patch. (Third > >> > > one will be mixer/sound support). Support is simple / pretty minimal, > >> > > but seems to work okay (and is somehow important for a cell phone > >:-). > >> > > >> > Pushed to linux-omap. I guess you're planning to send the missing > >> > Kconfig + Makefile patch for this? > >> > > >> > Also, it would be better to use omap_mcbsp_xmit_word() or > >> > omap_mcsbsp_spi_master_xmit_word_poll() instead of OMAP_MCBSP_WRITE as > >> > it does not do any checking that it worked. The aic23 and tsc2101 > >> > audio in linux-omap tree in general has the same problem. > >> > > >> > Regards, > >> > > >> > Tony > >> > > >> > >> Hmm. McBSP3 in SX1 is used in "GPIO mode". The only line used is CLKX, > >> so I think OMAP_MCBSP_WRITE would be enough. Am I wrong ? > >> - > > Again, framebuffer support patch is based on the omap framebuffer > driver, which is not yet submitted to upstream/fbdevel list. sx1 > framebuffer support just fill up the hooks required by -omap fb driver > framework. Yes, but the framebuffer code is in pretty much ready to be sent upstream :) Regards, Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/