Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 20 Jul 2021 16:49:32 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Aswath Govindraju <a-govindraju@ti.com>
Cc:     linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Nishanth Menon <nm@ti.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [PATCH 1/6] arm64: dts: ti: k3-am65-mcu: Add Support for MCAN
Message-ID: <20210720144932.5rtvpkmjooma7zae@pengutronix.de>
References: <20210720141642.24999-1-a-govindraju@ti.com>
 <20210720141642.24999-2-a-govindraju@ti.com>
 <20210720142047.mfqssyj4lwh3yi2k@pengutronix.de>
 <f3560ac8-8ffe-87d6-a21f-87f6251f1750@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hpvarmjcpm2ogbfr"
Content-Disposition: inline
In-Reply-To: <f3560ac8-8ffe-87d6-a21f-87f6251f1750@ti.com>
Precedence: bulk


--hpvarmjcpm2ogbfr
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 20.07.2021 20:00:32, Aswath Govindraju wrote:
> Hi Marc,
>=20
> On 20/07/21 7:50 pm, Marc Kleine-Budde wrote:
> > On 20.07.2021 19:46:37, Aswath Govindraju wrote:
> >> From: Faiz Abbas <faiz_abbas@ti.com>
> >>
> >> Add Support for two MCAN controllers present on the am65x SOC. Both su=
pport
> >> classic CAN messages as well as CAN-FD.
> >=20
> > Thanks for the patch!
> >=20
> > Why don't you disable the CAN cores by default in the dtsi?
>=20
> As far as I know, in the dtsi file we mention all the subsystems or
> periherals present in the SoC and in the specific board dts file we
> enable or disable the DT nodes depending on whether the  pins are
> brought out.

If you disable the subsystems (that need pins) by default, you only have
to list and configure only the used subsystems and not disable the
unused ones. But it seems in the TI land you're following the rule you
outlined above, so go ahead.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--hpvarmjcpm2ogbfr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmD24noACgkQqclaivrt
76n/7Qf+PEg9CDe1udrXT9AkQwMz291wPkLCnJ1ovwadeNE9O2Ntj0lqsFsdJikZ
Q6LXdiePRSKNgG0QaWasd4fU4sUOdBOXLvKCfvssW5GA1UfsMRYT+gECt4XaVdJ7
iGK+3T8PcygTvoalU8FrISpysm42BErouKENRQMa59yYJtAszH/RnB5VdtoM3M7u
x/NRGqcof/YZlx+UmtHhMsK2Tq1KdaUH+xH9B7Qi6HGcEXPFTTRehMhKZf5Re8hK
Ho91ZVWJfGQVPwHjP4C1MgXY8injX4Ib0ETYT4Psa8KPwE44YM0FrPq/ThwNR+Ff
97NPOogt5LaeAZXkztY32U7f5CgDkA==
=mTBU
-----END PGP SIGNATURE-----

--hpvarmjcpm2ogbfr--