Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4662240pxv; Tue, 20 Jul 2021 08:49:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzolrTObAzA8rwNeJVsra0orIBQf4/yLMjVcxq0WOFfjnojGT5dGDKIKzYaNiV2mYjMGn0l X-Received: by 2002:a17:906:69cc:: with SMTP id g12mr33410000ejs.550.1626796141040; Tue, 20 Jul 2021 08:49:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626796141; cv=none; d=google.com; s=arc-20160816; b=xf16KniXnea9ACGD9AWki0busUI16XDFY8c+KOAtlLyjf+bTmZiJ2dOo81qlazpdDK Up48QLHiNk38/KiPXQzNEDmD9SU2J+oKb/3/+T/A9r2NtUVHd//FpmdrCZM8Rc1YGwKf uvLBYcpUeI2/Fclog0WxTzieoRM9ocZxKBRzu7FBylYDG/S4LDSnHMceJ2MaXFunO/Lj LtvQj22ltYhaVvP6EZxnczLsLSfPw7k4VxxcUujCI2I5WbZHdL/UJVwT0lL+oxi90EZL uFw2M6vlLNsMQgX8V/5BfTvFEzCcETcRpwkFCuSTRzFbLYz68EvBwA3jYwbMyeY4E/hD tqXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=PxdJRybXj0b5kor3cTcrTlW6O+XJ2p80wJ3iq0K7/j8=; b=qSn9UB3QZ8agorzwKxDmT4wwqSqx9QkDt9MQC9y4G5dnW7earvA3dmsfnudz+AAFGj Lvkl6z5WTGEV69mrMFOAd+MGXKZmPPJ9yJXZVhtM78cApIeP4LCWuiTNjHyv1Lx6BP0r QZ5HcYPAsbXmniDmUYYL4u3IOfC5+PE8Pve3mn0N+ymbuG8ezgPes1EBEmYZLmLhUv3U NaS4TazdINtBg8qSgE9faofvorMIiVN4pXCfxVqvgnIlaUUOj6bsP0PZzA/rC5f/i+c0 Y0kN/U9YRIMqGZcw8W6MYF68FaK8aDzK5N6PkIQwDYVzFVt0jy1Tbawrvgc3Mpkdb/9B xQxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=A5Wq15YU; dkim=neutral (no key) header.i=@suse.de header.b=7qMtDYzU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g13si24803593edf.463.2021.07.20.08.48.36; Tue, 20 Jul 2021 08:49:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=A5Wq15YU; dkim=neutral (no key) header.i=@suse.de header.b=7qMtDYzU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240241AbhGTPGZ (ORCPT + 99 others); Tue, 20 Jul 2021 11:06:25 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:57420 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242160AbhGTO7s (ORCPT ); Tue, 20 Jul 2021 10:59:48 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 8978722453; Tue, 20 Jul 2021 15:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626795622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PxdJRybXj0b5kor3cTcrTlW6O+XJ2p80wJ3iq0K7/j8=; b=A5Wq15YU8vSgD4IWRe1+oClfodgFa8siOLcT4FZxf0P/y/jS+Y/f2XmA3eWxh54vKA4TT0 aCeZZU4KOk1M/N1r9XgdJDEmg0cpw66asaLBUsx2kCiNT1hZlznVIBe4Ld4RUrGNcjZmyP ef1X4RLiYNIETZn8IbZmqf7af+23Qow= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626795622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PxdJRybXj0b5kor3cTcrTlW6O+XJ2p80wJ3iq0K7/j8=; b=7qMtDYzURtCrQN9JWRU7bf5pfv1Rqs7Bhf9scnCsrxOjj8p4biEa2zly7kctAHPcO0ZiAs jLsJ8gZv7nW1PMDA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 71938A3B98; Tue, 20 Jul 2021 15:40:22 +0000 (UTC) Date: Tue, 20 Jul 2021 17:40:22 +0200 Message-ID: From: Takashi Iwai To: Colin King Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] ALSA: opti9xx: fix missing { } around an if block In-Reply-To: <20210720153741.73230-1-colin.king@canonical.com> References: <20210720153741.73230-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Jul 2021 17:37:41 +0200, Colin King wrote: > > From: Colin Ian King > > Currently the { } braces are missing around an if block causing subsequent > code after the return to become unreachable. Fix this by adding the > missing { }. > > Addresses-Coverity: ("Structurally dead code") > Fixes: 2973ee4a5b54 ("ALSA: opti9xx: Allocate resources with device-managed APIs") > Signed-off-by: Colin Ian King Thanks, applied. Takashi