Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 20 Jul 2021 17:29:05 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Emil Renner Berthing <kernel@esmil.dk>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Sebastian Reichel <sre@kernel.org>, devicetree@vger.kernel.org,
        linux-pm@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/3] mfd: tps65086: Make interrupt line optional
Message-ID: <YPb50VHKYrnmDkyK@google.com>
References: <20210625224744.1020108-1-kernel@esmil.dk>
 <20210625224744.1020108-3-kernel@esmil.dk>
 <YPbmmqfOuE5w6EgW@google.com>
 <CANBLGcy_28q23vRJk9=UZR_Feeqod-ETET=v4Ub=35edySH7SA@mail.gmail.com>
 <YPbsodxMk+VvU/3D@google.com>
 <CANBLGcx08XajR8khJmKARBjy7bQ5ebbgO+RRqRu=bvyMx7LuKA@mail.gmail.com>
 <YPb0spKPvEvuuMWc@google.com>
 <CANBLGcx2R4xuyoLHJUNbqiJeRrqTD1oL7X1K0RKzOPD_9xnMdw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CANBLGcx2R4xuyoLHJUNbqiJeRrqTD1oL7X1K0RKzOPD_9xnMdw@mail.gmail.com>
Precedence: bulk

On Tue, 20 Jul 2021, Emil Renner Berthing wrote:

> On Tue, 20 Jul 2021 at 18:07, Lee Jones <lee.jones@linaro.org> wrote:
> > On Tue, 20 Jul 2021, Emil Renner Berthing wrote:
> > > On Tue, 20 Jul 2021 at 17:32, Lee Jones <lee.jones@linaro.org> wrote:
> > > > On Tue, 20 Jul 2021, Emil Renner Berthing wrote:
> > > > > On Tue, 20 Jul 2021 at 17:07, Lee Jones <lee.jones@linaro.org> wrote:
> > > > > > On Sat, 26 Jun 2021, Emil Renner Berthing wrote:
> > > > > > > The BeagleV Starlight v0.9 board[1] doesn't have the IRQB line routed to
> > > > > > > the SoC, but it is still useful to be able to reach the PMIC over I2C
> > > > > > > for the other functionality it provides.
> > > > > > >
> > > > > > > [1] https://github.com/beagleboard/beaglev-starlight
> > > > > > >
> > > > > > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
> > > > > > > ---
> > > > > > >  .../devicetree/bindings/mfd/ti,tps65086.yaml  |  3 ---
> > > > > >
> > > > > > This is not present in my current tree.
> > > > > >
> > > > > > Looks like it's still *.txt.
> > > > > >
> > > > > > Am I missing a patch?
> > > > >
> > > > > Yes, the first patch in the series converts that to yaml. I'm quite
> > > > > sure I had the same list of recipients on all 4 mails in the series,
> > > > > so don't know why that should be missing.
> > > >
> > > > Oh, it's not marked as 'important' because it has open review comments
> > > > on it.
> > > >
> > > > Just have this for now then:
> > > >
> > > > For my own reference (apply this as-is to your sign-off block):
> > > >
> > > >   Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> > >
> > > Thanks! Do you want to have a look at 3/3 or should I just send a v2
> > > to fix the yaml conversion now?
> >
> > Patch 3 should be split.
> 
> Oh, how split? Split off the series or split into adding the "driver"
> and then add the cell to the parent?

I'm not overly concerned about the ordering.

Just split out the patch per-subsystem.

> > I think it should also s/restart/reset/.
> 
> Oh right yes. You mean the cell name needs to be .name =
> "tps65086-reset", right?

Right.

> I'll fix that anyway.

Ta.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog