Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] atm: idt77252: clean up trigraph warning on ??) string
To:     Colin King <colin.king@canonical.com>,
        Chas Williams <3chas3@gmail.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
        clang-built-linux@googlegroups.com
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210720124813.59331-1-colin.king@canonical.com>
From:   Nathan Chancellor <nathan@kernel.org>
Message-ID: <fd4f465b-86bd-129d-c6d9-e802b7c4815e@kernel.org>
Date:   Tue, 20 Jul 2021 10:17:45 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210720124813.59331-1-colin.king@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/20/2021 5:48 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The character sequence ??) is a trigraph and causes the following
> clang warning:
> 
> drivers/atm/idt77252.c:3544:35: warning: trigraph ignored [-Wtrigraphs]
> 
> Clean this by replacing it with single ?.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

This looks good to me but I am curious how you say this warning in the 
first place since the main Makefile disables this unconditionally. Did 
you just pass -Wtrigraphs via KCFLAGS or something similar?

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>   drivers/atm/idt77252.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
> index 9e4bd751db79..81ce81a75fc6 100644
> --- a/drivers/atm/idt77252.c
> +++ b/drivers/atm/idt77252.c
> @@ -3536,7 +3536,7 @@ static int idt77252_preset(struct idt77252_dev *card)
>   		return -1;
>   	}
>   	if (!(pci_command & PCI_COMMAND_IO)) {
> -		printk("%s: PCI_COMMAND: %04x (???)\n",
> +		printk("%s: PCI_COMMAND: %04x (?)\n",
>   		       card->name, pci_command);
>   		deinit_card(card);
>   		return (-1);
>