Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] atm: idt77252: clean up trigraph warning on ??) string
To:     Nathan Chancellor <nathan@kernel.org>,
        Chas Williams <3chas3@gmail.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
        clang-built-linux@googlegroups.com
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210720124813.59331-1-colin.king@canonical.com>
 <fd4f465b-86bd-129d-c6d9-e802b7c4815e@kernel.org>
From:   Colin Ian King <colin.king@canonical.com>
Message-ID: <5dc1f201-791e-3ca6-0b2d-49c270e572cf@canonical.com>
Date:   Tue, 20 Jul 2021 18:21:55 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <fd4f465b-86bd-129d-c6d9-e802b7c4815e@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 20/07/2021 18:17, Nathan Chancellor wrote:
> On 7/20/2021 5:48 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The character sequence ??) is a trigraph and causes the following
>> clang warning:
>>
>> drivers/atm/idt77252.c:3544:35: warning: trigraph ignored [-Wtrigraphs]
>>
>> Clean this by replacing it with single ?.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> This looks good to me but I am curious how you say this warning in the
> first place since the main Makefile disables this unconditionally. Did
> you just pass -Wtrigraphs via KCFLAGS or something similar?

I used W=1

> 
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> 
>> ---
>>   drivers/atm/idt77252.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
>> index 9e4bd751db79..81ce81a75fc6 100644
>> --- a/drivers/atm/idt77252.c
>> +++ b/drivers/atm/idt77252.c
>> @@ -3536,7 +3536,7 @@ static int idt77252_preset(struct idt77252_dev
>> *card)
>>           return -1;
>>       }
>>       if (!(pci_command & PCI_COMMAND_IO)) {
>> -        printk("%s: PCI_COMMAND: %04x (???)\n",
>> +        printk("%s: PCI_COMMAND: %04x (?)\n",
>>                  card->name, pci_command);
>>           deinit_card(card);
>>           return (-1);
>>