Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4996168pxv; Tue, 20 Jul 2021 16:39:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVN7AkpMcjWpMLXWRm5JQWK5Y6WCDojFbScaYzAvC7x6/FJncRKjChYc/L65Q6Jph64lZi X-Received: by 2002:aa7:c4c4:: with SMTP id p4mr45263372edr.367.1626824373895; Tue, 20 Jul 2021 16:39:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626824373; cv=none; d=google.com; s=arc-20160816; b=CcGIefB1Eeh8tR2ZzX1uVUC4U1/+EJRaCaX9wVZqL7Y0wAlrTJlNsXQ2HFMs07R696 Ic8voZmeTI1OMP6utmwFcdbW2rf+T/fbfsVNZZ9OTLPoLxPDa/CEUp9xmMFwsC6knw4k gDoc3ryoO7K7nDdub8P9035kOZrx9O9Qtc+W81DCknAV+e61E242RUONaGq3m1OBMkNS GNX3DcD7rt02e494spUE9kVT3S3f6L9kb3OGm+DIXClRTzymiytenOeWhbGadfBQlScP JwlbQAwkrQKvHbzaCkqxTa9YGhCTkx5J8cUPs6YzNPKJpktbDqnFr78Qo4OxBU1wN13R lRGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=tEPNOxkaSwVynI5bC9ITnmbjNbhpuULp2AY9Cx1gq1w=; b=zFSf4KLnskXAkZGj6hS3nhUrSJP6biIJ62xXiRqnfSFE+aaWqPt0P8WEdG5vv7/pee 5i4OznoiBLr4Ys6V3bf4XKoLSWXyv8EH5B2AePXcAcU82WuYpKFClCGKZn9wjMnL44Cg yIVLUl2Y3QZa7yL7dG8J5mYSin6ZTnepjhlz3HtnsLfi5dX8Y/AoYVtrGw42JJDn0TlR /g4HaKC6h0ukAJT5jOuH61cg3i0lB2luxvg4tgK+HSFUiHMwUvp42Q54SLwFusFwNdqf Kv2dVtqYqOcYtqGA9RjOWX4V9r/5pAql30x1++HCzflX8JReVtdPuqU+tfykBd3dh7Vs CeEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="a/n+JuUB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c22si21765917eds.106.2021.07.20.16.39.10; Tue, 20 Jul 2021 16:39:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="a/n+JuUB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236098AbhGTWvn (ORCPT + 99 others); Tue, 20 Jul 2021 18:51:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32236 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236223AbhGTWrV (ORCPT ); Tue, 20 Jul 2021 18:47:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626823677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tEPNOxkaSwVynI5bC9ITnmbjNbhpuULp2AY9Cx1gq1w=; b=a/n+JuUB5hf98u8shmXO6KWpK0DRPrjTGkueaGN8LYDmHw4aLbSo+fiQsIXcB5IbS55XNO kPbn1iFRBnN6SNw4mBrZpYRDvpdkxxW0PIcFLwsSErNR/xx2ivGjp3LN1Iu6eN75tP3hOm fhapB+7nWwoA/dgM2cUAi+JTd0cUZJ4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247-BA7Jin6zPPO1eS4usxWFSA-1; Tue, 20 Jul 2021 19:27:56 -0400 X-MC-Unique: BA7Jin6zPPO1eS4usxWFSA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 04179100C618; Tue, 20 Jul 2021 23:27:55 +0000 (UTC) Received: from virtlab719.virt.lab.eng.bos.redhat.com (virtlab719.virt.lab.eng.bos.redhat.com [10.19.153.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6462B69CB4; Tue, 20 Jul 2021 23:27:50 +0000 (UTC) From: Nitesh Narayan Lal To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-pci@vger.kernel.org, tglx@linutronix.de, jesse.brandeburg@intel.com, robin.murphy@arm.com, mtosatti@redhat.com, mingo@kernel.org, jbrandeb@kernel.org, frederic@kernel.org, juri.lelli@redhat.com, abelits@marvell.com, bhelgaas@google.com, rostedt@goodmis.org, peterz@infradead.org, davem@davemloft.net, akpm@linux-foundation.org, sfr@canb.auug.org.au, stephen@networkplumber.org, rppt@linux.vnet.ibm.com, chris.friesen@windriver.com, maz@kernel.org, nhorman@tuxdriver.com, pjwaskiewicz@gmail.com, sassmann@redhat.com, thenzl@redhat.com, kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, james.smart@broadcom.com, dick.kennedy@broadcom.com, jkc@redhat.com, faisal.latif@intel.com, shiraz.saleem@intel.com, tariqt@nvidia.com, ahleihel@redhat.com, kheib@redhat.com, borisp@nvidia.com, saeedm@nvidia.com, benve@cisco.com, govind@gmx.com, jassisinghbrar@gmail.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, nilal@redhat.com, tatyana.e.nikolova@intel.com, mustafa.ismail@intel.com, ahs3@redhat.com, leonro@nvidia.com, chandrakanth.patil@broadcom.com, bjorn.andersson@linaro.org, chunkuang.hu@kernel.org, yongqiang.niu@mediatek.com, baolin.wang7@gmail.com, poros@redhat.com, minlei@redhat.com, emilne@redhat.com, jejb@linux.ibm.com, martin.petersen@oracle.com, _govind@gmx.com, kabel@kernel.org, viresh.kumar@linaro.org, Tushar.Khandelwal@arm.com, kuba@kernel.org Subject: [PATCH v5 14/14] net/mlx4: Use irq_update_affinity_hint Date: Tue, 20 Jul 2021 19:26:24 -0400 Message-Id: <20210720232624.1493424-15-nitesh@redhat.com> In-Reply-To: <20210720232624.1493424-1-nitesh@redhat.com> References: <20210720232624.1493424-1-nitesh@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver uses irq_set_affinity_hint() to update the affinity_hint mask that is consumed by the userspace to distribute the interrupts. However, under the hood irq_set_affinity_hint() also applies the provided cpumask (if not NULL) as the affinity for the given interrupt which is an undocumented side effect. To remove this side effect irq_set_affinity_hint() has been marked as deprecated and new interfaces have been introduced. Hence, replace the irq_set_affinity_hint() with the new interface irq_update_affinity_hint() that only updates the affinity_hint pointer. Signed-off-by: Nitesh Narayan Lal Reviewed-by: Leon Romanovsky Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/eq.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c index 9e48509ed3b2..414e390e6b48 100644 --- a/drivers/net/ethernet/mellanox/mlx4/eq.c +++ b/drivers/net/ethernet/mellanox/mlx4/eq.c @@ -244,9 +244,9 @@ static void mlx4_set_eq_affinity_hint(struct mlx4_priv *priv, int vec) cpumask_empty(eq->affinity_mask)) return; - hint_err = irq_set_affinity_hint(eq->irq, eq->affinity_mask); + hint_err = irq_update_affinity_hint(eq->irq, eq->affinity_mask); if (hint_err) - mlx4_warn(dev, "irq_set_affinity_hint failed, err %d\n", hint_err); + mlx4_warn(dev, "irq_update_affinity_hint failed, err %d\n", hint_err); } #endif @@ -1123,9 +1123,7 @@ static void mlx4_free_irqs(struct mlx4_dev *dev) for (i = 0; i < dev->caps.num_comp_vectors + 1; ++i) if (eq_table->eq[i].have_irq) { free_cpumask_var(eq_table->eq[i].affinity_mask); -#if defined(CONFIG_SMP) - irq_set_affinity_hint(eq_table->eq[i].irq, NULL); -#endif + irq_update_affinity_hint(eq_table->eq[i].irq, NULL); free_irq(eq_table->eq[i].irq, eq_table->eq + i); eq_table->eq[i].have_irq = 0; } -- 2.27.0