Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4996379pxv; Tue, 20 Jul 2021 16:39:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJa8VOpiYVV84bMOIBVIYdzSD2KLynvOmrIXoxtDaM+6TuNprw+UGfxOUsCB5eSYFm1g3d X-Received: by 2002:a17:906:c055:: with SMTP id bm21mr35654132ejb.350.1626824396324; Tue, 20 Jul 2021 16:39:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626824396; cv=none; d=google.com; s=arc-20160816; b=tvWfh9x1EBn2a/JqF0CWdxvzFS6QEEY97iMZCMzvOeSX5DpX2x3uDwoXKJ4cRIz81+ EOGbRJSPfBVXMGKheiylr//Q2ww7g5aq90fMMzzfcgXIf45ZpNadAQx2j0rnSAGtFeaU SqcLRQvkcDGzG4D/3UOR8Q7+kEeoZyl0r901MZv6AIdy8UKzwjgVBP6ikgyNlxu0Da1Q sBnJO84PHHxcS0r2TA5JSq8Odd+UzFdVkLVCqdKxI7InMy7V2UarEdmBYNGZonOO6bM0 Yo0uawW4s6RJu8LD8JUXdYPMRGRntd7QOGIuGQ2plx9PY+5Zp2OxUHzcl0az5nmhKNKb YcNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=zuZd/erhcH5JqKd76Lbo99r5gRHYSZoylCGlNGoCcSY=; b=pOBpCLRvXcpZjRWMB/rAFB7Y5mZ2nD+zYAHpZyotLNQrNNIZFbpMMmRGFqcDthabT+ XA8lxrr9BBvj5HwNJCBrUvSYWVINLDW2xLiHkBHVm8r9BEDLs3UD366bgObs7H/Oomsr WXPTMrjKUhDuMJOniSqU2J2yZZja1pBdvqcUF/MBGY1t2Q6hlv3jAySHS7/F44v0QvK7 kE7Ow2pVOWrBiMcFwOs2TFDjKyWvgrkTZeN0WnX5K+1vi0bYHQWcmTj2L/XJznvIEB4K ghOFF9+hw23QAQd50+ARkIFQCo6Y9pnbAt1MuPjG7jguM/BhciNWEtBGhgH+RA3f9c/+ dZMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FJIT0wQK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y12si13433253edt.124.2021.07.20.16.39.32; Tue, 20 Jul 2021 16:39:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FJIT0wQK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237449AbhGTWzz (ORCPT + 99 others); Tue, 20 Jul 2021 18:55:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34836 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235651AbhGTWqf (ORCPT ); Tue, 20 Jul 2021 18:46:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626823633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zuZd/erhcH5JqKd76Lbo99r5gRHYSZoylCGlNGoCcSY=; b=FJIT0wQKWZrl5UPZho/U0SKV7P5ZqmcywYHQ9h8l0sAdlssUDycf3D1gaQ9W0xeppLSmyG AR6y/WW235pqb6E39/0qU2w1LOjqSjUhJegs26nnYslaMxB4zAnCKOrbuLCYPbWiv47k0n z4Wl84xP2ot9MN3p6mpabzRKvorO9Es= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-307-6zAPg_1qOTCDfODJHYRTeQ-1; Tue, 20 Jul 2021 19:27:12 -0400 X-MC-Unique: 6zAPg_1qOTCDfODJHYRTeQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6166E1084F4B; Tue, 20 Jul 2021 23:27:10 +0000 (UTC) Received: from virtlab719.virt.lab.eng.bos.redhat.com (virtlab719.virt.lab.eng.bos.redhat.com [10.19.153.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id AED9669CB4; Tue, 20 Jul 2021 23:27:05 +0000 (UTC) From: Nitesh Narayan Lal To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-pci@vger.kernel.org, tglx@linutronix.de, jesse.brandeburg@intel.com, robin.murphy@arm.com, mtosatti@redhat.com, mingo@kernel.org, jbrandeb@kernel.org, frederic@kernel.org, juri.lelli@redhat.com, abelits@marvell.com, bhelgaas@google.com, rostedt@goodmis.org, peterz@infradead.org, davem@davemloft.net, akpm@linux-foundation.org, sfr@canb.auug.org.au, stephen@networkplumber.org, rppt@linux.vnet.ibm.com, chris.friesen@windriver.com, maz@kernel.org, nhorman@tuxdriver.com, pjwaskiewicz@gmail.com, sassmann@redhat.com, thenzl@redhat.com, kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, james.smart@broadcom.com, dick.kennedy@broadcom.com, jkc@redhat.com, faisal.latif@intel.com, shiraz.saleem@intel.com, tariqt@nvidia.com, ahleihel@redhat.com, kheib@redhat.com, borisp@nvidia.com, saeedm@nvidia.com, benve@cisco.com, govind@gmx.com, jassisinghbrar@gmail.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, nilal@redhat.com, tatyana.e.nikolova@intel.com, mustafa.ismail@intel.com, ahs3@redhat.com, leonro@nvidia.com, chandrakanth.patil@broadcom.com, bjorn.andersson@linaro.org, chunkuang.hu@kernel.org, yongqiang.niu@mediatek.com, baolin.wang7@gmail.com, poros@redhat.com, minlei@redhat.com, emilne@redhat.com, jejb@linux.ibm.com, martin.petersen@oracle.com, _govind@gmx.com, kabel@kernel.org, viresh.kumar@linaro.org, Tushar.Khandelwal@arm.com, kuba@kernel.org Subject: [PATCH v5 06/14] RDMA/irdma: Use irq_update_affinity_hint Date: Tue, 20 Jul 2021 19:26:16 -0400 Message-Id: <20210720232624.1493424-7-nitesh@redhat.com> In-Reply-To: <20210720232624.1493424-1-nitesh@redhat.com> References: <20210720232624.1493424-1-nitesh@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver uses irq_set_affinity_hint() to update the affinity_hint mask that is consumed by the userspace to distribute the interrupts. However, under the hood irq_set_affinity_hint() also applies the provided cpumask (if not NULL) as the affinity for the given interrupt which is an undocumented side effect. To remove this side effect irq_set_affinity_hint() has been marked as deprecated and new interfaces have been introduced. Hence, replace the irq_set_affinity_hint() with the new interface irq_update_affinity_hint() that only updates the affinity_hint pointer. Signed-off-by: Nitesh Narayan Lal --- drivers/infiniband/hw/irdma/hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c index 7afb8a6a0526..ec8de708a4df 100644 --- a/drivers/infiniband/hw/irdma/hw.c +++ b/drivers/infiniband/hw/irdma/hw.c @@ -537,7 +537,7 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf, struct irdma_sc_dev *dev = &rf->sc_dev; dev->irq_ops->irdma_dis_irq(dev, msix_vec->idx); - irq_set_affinity_hint(msix_vec->irq, NULL); + irq_update_affinity_hint(msix_vec->irq, NULL); free_irq(msix_vec->irq, dev_id); } @@ -1087,7 +1087,7 @@ irdma_cfg_ceq_vector(struct irdma_pci_f *rf, struct irdma_ceq *iwceq, } cpumask_clear(&msix_vec->mask); cpumask_set_cpu(msix_vec->cpu_affinity, &msix_vec->mask); - irq_set_affinity_hint(msix_vec->irq, &msix_vec->mask); + irq_update_affinity_hint(msix_vec->irq, &msix_vec->mask); if (status) { ibdev_dbg(&rf->iwdev->ibdev, "ERR: ceq irq config fail\n"); return IRDMA_ERR_CFG; -- 2.27.0