Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 20 Jul 2021 19:02:53 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Ming Lei <ming.lei@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH V2] genirq/affinity: add helper of irq_affinity_calc_sets
Message-ID: <20210721000253.GA143407@bjorn-Precision-5520>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210720075025.GA17565@lst.de>
Precedence: bulk

On Tue, Jul 20, 2021 at 09:50:25AM +0200, Christoph Hellwig wrote:
> > +int irq_affinity_calc_sets(unsigned int affvecs, struct irq_affinity *affd)
> > +{
> > +	/*
> > +	 * Simple invocations do not provide a calc_sets() callback. Call
> > +	 * the generic one.
> > +	 */
> > +	if (!affd->calc_sets)
> > +		default_calc_sets(affd, affvecs);
> > +	else
> > +		affd->calc_sets(affd, affvecs);
> 
> Nit: avoid pointless negations:
> 
> 	if (affd->calc_sets)
> 		affd->calc_sets(affd, affvecs);
> 	else
> 		default_calc_sets(affd, affvecs);

+1

> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks for doing this!  For the PCI part:

Acked-by: Bjorn Helgaas <bhelgaas@google.com>