Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5183493pxv; Tue, 20 Jul 2021 22:28:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXPdJ1Dcbp4QAkvDLoi/26wreLf7MWMUKt03bv+Xa/az68WvcuOHWTQmu+EqFvZn7RKK2w X-Received: by 2002:a05:6402:33a:: with SMTP id q26mr45330231edw.369.1626845315789; Tue, 20 Jul 2021 22:28:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626845315; cv=none; d=google.com; s=arc-20160816; b=fZDuMqdX5KgdeqEA0ediz1WdYpEvsfoHDDvyTi18YsDFgIAAF3KPxJVIsOvNFc3Ubg IoRvtIvylxI950gg0jVhKkEYl3a5G9ymkgcnno4p4fYof+2IqFL1rsAWka0WPffYM8zB UBYvvhIbsH1fHSAhO8ClSqqQE96AaK0UVOiboAtPsNgj9N1+Ruk3wKfUHQZm/yp0a2Fd 7xIFlpOYt7ngnK1+quBL7DG7NfOEhQLQxgit58ZNOMl5/uAuTxwaK5ZSDAqKkPw/xoGO w2MW8BuqOhIkoyhW9RWj3mKZHz/Urlbggf9rMK1Nc6/27r7KbvXWvmYlB0Vo3YYvGIsz g4zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mgYRCt/WE3g4ArIxNSEiTBCKixk35dYvntS3C3v4Ldo=; b=VaZju93/3JrhajNYz7VAMhP2Gyqk3gk9+2nELFEOZyI9fjJe1Oc59QP9CF8s3vzaB4 Ln7UxaQeAdi1knVrKkjvoS+qKgBEy2BOFaMQtbaOimGEMhjdxywJ6sr4VOq/P0dRNqYC V5BmyJyu9AUfVcQIeA9MDWQUCQhhDK80lqryBUYYPi8/w9rrLVbrhn/nnYi8s2K+mwTm 0ofvGdPP4kyZqwhRzojZQL8sB29jJlgpveudBUu1Uincm51dqaRMU8JVIzrxVm7LBKnL ZdMJPlAUoiMC/Q6iiJw49ri7F4cJDZ+lVC5fvIMW+oiZntiQOPbryDRSri6AE9XCcqbw 3Xsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=UH6q4VDp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si26462704ejx.283.2021.07.20.22.28.12; Tue, 20 Jul 2021 22:28:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=UH6q4VDp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231139AbhGUEqF (ORCPT + 99 others); Wed, 21 Jul 2021 00:46:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232035AbhGUEp5 (ORCPT ); Wed, 21 Jul 2021 00:45:57 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 420D4C061574; Tue, 20 Jul 2021 22:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mgYRCt/WE3g4ArIxNSEiTBCKixk35dYvntS3C3v4Ldo=; b=UH6q4VDp5NmuztLkKO306ATLmk dkC382GW2mo/epktRxsbWcM/OTc4YVIjbCq6QveK9kM2dIGSyV0rn1d/IaDQH1iln+CMS0nmIKoLn 2XD8Za+B6l3UJ1an7XRdhUNcM/AmpTwrPuLAvt3zZhDGwUXNNW0O+yIVkU1p+eF6BhPYlXo4G1TTl 6xNDT39V374WYlyfKgcOW/Eo6vVmlY3kRU2+YmbpnlE33q2B4f86OMJS08WNvTKGN/fhioYYoZjD0 DqZNeQfs3nlWuTks2fWOWHmWZeozjF86mpjysP0QwmPrUDzXQcYvFKMeGg6xkcVJDRHzz0Unp/YRU F8yjDATg==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m64jz-008pL4-Mt; Wed, 21 Jul 2021 05:25:59 +0000 Date: Wed, 21 Jul 2021 06:25:55 +0100 From: Christoph Hellwig To: Luis Chamberlain Cc: axboe@kernel.dk, hare@suse.de, bvanassche@acm.org, ming.lei@redhat.com, hch@infradead.org, jack@suse.cz, osandov@fb.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] fs/block_dev: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED Message-ID: References: <20210720182048.1906526-1-mcgrof@kernel.org> <20210720182048.1906526-6-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720182048.1906526-6-mcgrof@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 20, 2021 at 11:20:48AM -0700, Luis Chamberlain wrote: > The GENHD_FL_DISK_ADDED flag is what we really want, as the > flag GENHD_FL_UP could be set on a semi-initialized device. No. Here we must reject opens once del_gendisk has been called.