Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031382AbWKUUS3 (ORCPT ); Tue, 21 Nov 2006 15:18:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934411AbWKUUS3 (ORCPT ); Tue, 21 Nov 2006 15:18:29 -0500 Received: from mx2.cs.washington.edu ([128.208.2.105]:10720 "EHLO mx2.cs.washington.edu") by vger.kernel.org with ESMTP id S934402AbWKUUS2 (ORCPT ); Tue, 21 Nov 2006 15:18:28 -0500 Date: Tue, 21 Nov 2006 12:18:12 -0800 (PST) From: David Rientjes To: d binderman cc: Andi Kleen , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: arch/x86_64/kernel/apic.c(701): remark #593: variable "ver" was set but never us In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1394 Lines: 41 Remove unused GET_APIC_VERSION call from clear_local_APIC() and __setup_APIC_LVTT(). Reported by D Binderman . Cc: Andi Kleen Cc: Ingo Molnar Signed-off-by: David Rientjes --- arch/x86_64/kernel/apic.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/x86_64/kernel/apic.c b/arch/x86_64/kernel/apic.c index 4d9d5ed..96743aa 100644 --- a/arch/x86_64/kernel/apic.c +++ b/arch/x86_64/kernel/apic.c @@ -133,7 +133,6 @@ void clear_local_APIC(void) apic_write(APIC_LVTERR, APIC_LVT_MASKED); if (maxlvt >= 4) apic_write(APIC_LVTPC, APIC_LVT_MASKED); - v = GET_APIC_VERSION(apic_read(APIC_LVR)); apic_write(APIC_ESR, 0); apic_read(APIC_ESR); } @@ -644,10 +643,9 @@ #define APIC_DIVISOR 16 static void __setup_APIC_LVTT(unsigned int clocks) { - unsigned int lvtt_value, tmp_value, ver; + unsigned int lvtt_value, tmp_value; int cpu = smp_processor_id(); - ver = GET_APIC_VERSION(apic_read(APIC_LVR)); lvtt_value = APIC_LVT_TIMER_PERIODIC | LOCAL_TIMER_VECTOR; if (cpu_isset(cpu, timer_interrupt_broadcast_ipi_mask)) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/