Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5218343pxv; Tue, 20 Jul 2021 23:33:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjnwDm4SH8XoHOkDObAi4OafE9gc4BaX8Y4xjs33Kvc2yct2KHGX7JAVATiOhyYO2iewHD X-Received: by 2002:a92:d10:: with SMTP id 16mr22960358iln.189.1626849198942; Tue, 20 Jul 2021 23:33:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626849198; cv=none; d=google.com; s=arc-20160816; b=I+zWXn+RjKFu9rvtZcv3xaI8IqGcTRZmg7YT0S+r/rznzwyZqpz5O/YBh9L8C61zlI qhLC8ZcNuhkeEXNsGhcvST4E4nQG3V4jsro9jugA7y5PISjo0kJI1ElwUZXDfZYtBwmK Tqd/sdJn29mF9NeKH/MfObIEKNSPd2GWFARm7Oqths65E4Or7w+POlwDBuNkILRwt1eU XIx2fOn/edM33jABzmUPg1kQzYngWSBdraMCiMI15D6eui8aqQUoLc2ZR5Dz1ODpdVH7 RxvQpnJBPNqke6Jf8KB/oBSVlSuDDf6NHneGkQAgtV8IBWF1J5P8IYEzR9tItI2klT7t OnYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=wL/K86g0ts3ZBkvO24FA7/hEHLPSc9puxHO4lfZjq4Y=; b=uWoT+ae8Vr4eyhBy+iCkDJp2QQ8QcAQFd41ndR6k8G5kkPAhctV/oB3RrPS+pK/3aj n5PrOAmFYWl8WV9t3W+3qClnYA34Ecovo+2tcEuaACF6BBzlo4/JKWxMirEFZD3uKcIJ jjAr4XJZLWUm60WD4WNqWbf8kXMuKRdpgnomaLLAlPYuDiFaEjAmUnzel1OLeYqarw9O zqkzZK4FddLEwxZsgxRme665GquX1rQNLE55mY/2LfSTjgmbXO7iQR1KznF5UiC9BBSM GWv9v6msZqPmt5FAch4G9GNo4rrmJA44mi9VZD8oTmSgfbuPRnIh+WKj/cszPRGoiz9s dRlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l11si2079581ilh.40.2021.07.20.23.33.07; Tue, 20 Jul 2021 23:33:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233921AbhGUFvU (ORCPT + 99 others); Wed, 21 Jul 2021 01:51:20 -0400 Received: from lucky1.263xmail.com ([211.157.147.132]:52384 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233518AbhGUFvC (ORCPT ); Wed, 21 Jul 2021 01:51:02 -0400 Received: from localhost (unknown [192.168.167.70]) by lucky1.263xmail.com (Postfix) with ESMTP id 952D3FAEFA; Wed, 21 Jul 2021 14:31:20 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED: 0 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from localhost.localdomain (unknown [113.57.152.160]) by smtp.263.net (postfix) whith ESMTP id P13644T140561943324416S1626849079568135_; Wed, 21 Jul 2021 14:31:20 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <77a0db2e198c30d823326db2b8920101> X-RL-SENDER: liubaozhu@uniontech.com X-SENDER: liubaozhu@uniontech.com X-LOGIN-NAME: liubaozhu@uniontech.com X-FST-TO: paolo.valente@linaro.org X-RCPT-COUNT: 5 X-SENDER-IP: 113.57.152.160 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 From: liubaozhu To: paolo.valente@linaro.org Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, liubaozhu Subject: [PATCH] block/bfq: the delta_from_first should be ns rather than us Date: Wed, 21 Jul 2021 14:30:47 +0800 Message-Id: <20210721063047.92122-1-liubaozhu@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the block/bfq-iosched.c,the function bfq_update_peak_rate(), bfqd->delta_from_first = now_ns - bfqd->first_dispatch, according to the subtraction operation here,now_ns is ns, and bfqd->first_dispatch is also ns,so bfqd->delta_from_first should be ns. Signed-off-by: liubaozhu --- block/bfq-iosched.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h index 99c2a3cb0..7cf4fc8c3 100644 --- a/block/bfq-iosched.h +++ b/block/bfq-iosched.h @@ -632,7 +632,7 @@ struct bfq_data { u64 tot_sectors_dispatched; /* max rq size seen during current observation interval (sectors) */ u32 last_rq_max_size; - /* time elapsed from first dispatch in current observ. interval (us) */ + /* time elapsed from first dispatch in current observ. interval (ns) */ u64 delta_from_first; /* * Current estimate of the device peak rate, measured in -- 2.20.1