Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Jul 2021 07:45:48 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
        Mark Zhang <markz@mellanox.com>
Subject: Re: [PATCH rdma-next 4/7] RDMA/core: Reorganize create QP low-level
 functions
Message-ID: <YPfCnIfVmolgfMPF@infradead.org>
References: <cover.1626846795.git.leonro@nvidia.com>
 <328963df8e30bfc040c846d2c7626becd341f3ec.1626846795.git.leonro@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <328963df8e30bfc040c846d2c7626becd341f3ec.1626846795.git.leonro@nvidia.com>
Precedence: bulk

> +/**
> + * ib_create_qp_kernel - Creates a kernel QP associated with the specified

Any reason this function is renamed?  This seems rather unrelated to
the rest of th patch.

> + *   protection domain.
>   * @pd: The protection domain associated with the QP.
>   * @qp_init_attr: A list of initial attributes required to create the
>   *   QP.  If QP creation succeeds, then the attributes are updated to
>   *   the actual capabilities of the created QP.
>   * @caller: caller's build-time module name
> - *
> - * NOTE: for user qp use ib_create_qp_user with valid udata!
>   */

Also a kerneldoc comment for a function that is an implementation
detail is actively harmful.  Please document ib_create_qp instead.