Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Jul 2021 07:48:48 +0100
From:   Christoph Hellwig <hch@infradead.org>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
        Mark Zhang <markz@mellanox.com>
Subject: Re: [PATCH rdma-next 7/7] RDMA/core: Create clean QP creations
 interface for uverbs
Message-ID: <YPfDUN6CaOdGZLPS@infradead.org>
References: <cover.1626846795.git.leonro@nvidia.com>
 <8eaf125d3bfb463e1641b6f2794203cc93d76c90.1626846795.git.leonro@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8eaf125d3bfb463e1641b6f2794203cc93d76c90.1626846795.git.leonro@nvidia.com>
Precedence: bulk

> +struct ib_qp *ib_create_qp_user(struct ib_device *dev, struct ib_pd *pd,
> +				struct ib_qp_init_attr *attr,
> +				struct ib_udata *udata,
> +				struct ib_uqp_object *uobj, const char *caller);
> +static inline struct ib_qp *ib_create_qp_uverbs(struct ib_device *dev,
> +						struct ib_pd *pd,
> +						struct ib_qp_init_attr *attr,
> +						struct ib_udata *udata,
> +						struct ib_uqp_object *uobj)
> +{
> +	if (attr->qp_type == IB_QPT_XRC_TGT)
> +		return ib_create_qp_user(dev, pd, attr, NULL, uobj,
> +					 KBUILD_MODNAME);
> +
> +	return ib_create_qp_user(dev, pd, attr, udata, uobj, NULL);

Why not always pass along the udata and caller and just not use them
in the low-level code?