Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Jul 2021 09:56:54 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, Mark Zhang <markz@mellanox.com>
Subject: Re: [PATCH rdma-next 3/7] RDMA/core: Remove protection from wrong
 in-kernel API usage
Message-ID: <YPfFNvdw/UPNR9Mb@unreal>
References: <cover.1626846795.git.leonro@nvidia.com>
 <8084238e374fe487c3f9728c2ee5ec8736c204d5.1626846795.git.leonro@nvidia.com>
 <YPfBiDdghnRwSjwG@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YPfBiDdghnRwSjwG@infradead.org>
Precedence: bulk

On Wed, Jul 21, 2021 at 07:41:12AM +0100, Christoph Hellwig wrote:
> On Wed, Jul 21, 2021 at 09:13:02AM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> > 
> > The ib_create_named_qp() is kernel verb that is not used for user
> > supplied attributes. In such case, it is ULP responsibility to provide
> > valid QP attributes.
> > 
> > In-kernel API shouldn't check it, exactly like other functions that
> > don't check device capabilities.
> 
> Hmm.  These still looks like useful debugging checks.

All in-tree ULPs already set properly based on device capabilities.

Thanks