Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Jul 2021 10:31:08 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, Mark Zhang <markz@mellanox.com>
Subject: Re: [PATCH rdma-next 7/7] RDMA/core: Create clean QP creations
 interface for uverbs
Message-ID: <YPfNPL8qWcvMVyD2@unreal>
References: <cover.1626846795.git.leonro@nvidia.com>
 <8eaf125d3bfb463e1641b6f2794203cc93d76c90.1626846795.git.leonro@nvidia.com>
 <YPfDUN6CaOdGZLPS@infradead.org>
 <YPfHXpFtB1RJ4yjU@unreal>
 <YPfI4+M/Ula5a0KZ@infradead.org>
 <YPfK0VHovcc45heP@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YPfK0VHovcc45heP@infradead.org>
Precedence: bulk

On Wed, Jul 21, 2021 at 08:20:49AM +0100, Christoph Hellwig wrote:
> On Wed, Jul 21, 2021 at 08:12:35AM +0100, Christoph Hellwig wrote:
> > On Wed, Jul 21, 2021 at 10:06:06AM +0300, Leon Romanovsky wrote:
> > > You will need to add some sort of "if qp tpye" for ib_create_qp_uverbs() callers,
> > > because they always provide udata != NULL. 
> > > 
> > > After this series, the callers look like this:
> > > 
> > >  1438         qp = ib_create_qp_uverbs(device, pd, &attr, &attrs->driver_udata, obj);
> > >                                                           ^^^^^^^^^ not NULL
> > > 
> > > So instead of bothering callers, I implemented it here with one "if".
> > 
> > Sorry if my mail was confusing.  I don't want it in the callers, I
> > want it as deep down in the stack as possible instead of having the
> > strange wrapper.
> 
> In fact ib_create_qp_user already sets udata to NULL for IB_QPT_XRC_TGT,
> and _ib_create_qp/create_qp ignores the caller if the udata is NULL.
> So I think you can just remove the wrapper and we're already fine.

Yeah, thanks