Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5261559pxv; Wed, 21 Jul 2021 00:54:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHXs+XiloYhzF4UcpDqa7/o9wU6XzkJxe5GQLv19PbGBBDNqbhvFpWvJ2m0DoSP7dwRXjW X-Received: by 2002:a17:906:6d54:: with SMTP id a20mr37554473ejt.322.1626854072538; Wed, 21 Jul 2021 00:54:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626854072; cv=none; d=google.com; s=arc-20160816; b=cwJIOr5jwtfT/xvkP/vPhAQz14iLE9QRmYihoS6IdHW23hoJ4hp3A3ydtVpWV+yQVE c6kCeX3Z/tX7tE/typA+kYrC1Kyp+AhlPtHyvJ5C1vxdxM7CDXWbilDV2MJE6veGLy1Y qmnJ3i6djXBF33oxyq70yp07E4qlVLTNky+FXZMmxlR3/TpbY10F05q7HTadOjGpWHQO +kYAGb3NGGEsShbRGkxH7WRT3BiHhBmYf2+vppKyJNtoVdKeJoYO+ItTW7PlXrPgXbpF OxfSSkx1hk8EOGsXH++6awkp22gru2YvMghjCAu77ciAMha+kP8gKYv4CG7kV5NQsqlC vgaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=r3ZO71nzO3kL9BkSEFcz1MpXkAUT4jB2lXyxFEnaMDs=; b=VdK2AdFFkbfh9++mu9U21EQs/+pzPC0Q7vJQLTAMaQzUEdZYf7jE/G2riVr8ZEYC/b yPKba2EzxoBOibftoqJuwme9FtZebrU6BttHV0fSPHafE/KKiPA8nwB0Qo00QIrFxSTC QQdgLX4w0/hvFEPm2kZE3GgQkesavoE8Pqn5Eiv5YT3qPh3GVlsxor0lddJ8/cLb6fte jTXk1BRk7mxgVjL98xKKtZwcpBKXU92gn/ugaaZkf9KTXQ1R6U7bB3dDsQBYoYIECbix f1Etb7z7iGl5rrFz4j12GGy7WkXlUV2DRrIcmmV9ApT9WhuP/1gEJYlDZVY1gROAVwBF nDVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TFr9PKZE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o3si4403647edt.495.2021.07.21.00.54.09; Wed, 21 Jul 2021 00:54:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TFr9PKZE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235538AbhGUHKC (ORCPT + 99 others); Wed, 21 Jul 2021 03:10:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:39870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235869AbhGUHJR (ORCPT ); Wed, 21 Jul 2021 03:09:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 083A9611C1; Wed, 21 Jul 2021 07:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626853793; bh=NiAJktv7ds+8oKSDNOTKvzGUhZmEmpyNWO4ZqNTOKkc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TFr9PKZEaWZ1nQXZa8lR21YIcIUfrVKgjHhFCCLi9A2jWAlMSs7erV26W8yLyyzro 04j5UUqK1bk4ho7WtzCjq6clfuczklHHke6g6a1CP2ds7RTgWM6zqG0AwHGirYaY6J WuBeozLqluxktzZXhZDQmKwscn/UZV72hQTT6CYSJbA8V/msE67dsVzgO5iQiZlucS SxUEgzlfw6tot/u9pgPZmSI9qMkyL4hdLmqHhSStX6wN0IjNOKh9hpkQPaMbFfgTTl IgtPDTJGikFSwZ93sRfp7Kpylrwpwl8sBFlsJ9gr26dPGIEQyrD/5ZBknoICyvPXub PefzkmH5tX3oA== Date: Wed, 21 Jul 2021 10:49:50 +0300 From: Leon Romanovsky To: Mark Zhang Cc: Doug Ledford , Jason Gunthorpe , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Mark Zhang Subject: Re: [PATCH rdma-next 4/7] RDMA/core: Reorganize create QP low-level functions Message-ID: References: <328963df8e30bfc040c846d2c7626becd341f3ec.1626846795.git.leonro@nvidia.com> <11e8e739-99b4-8ebe-38e1-de36b21b0f25@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11e8e739-99b4-8ebe-38e1-de36b21b0f25@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 21, 2021 at 03:47:34PM +0800, Mark Zhang wrote: > On 7/21/2021 2:13 PM, Leon Romanovsky wrote: > > External email: Use caution opening links or attachments > > > > > > From: Leon Romanovsky > > > > The low-level create QP function grew to be larger than any sensible > > incline function should be. The inline attribute is not really needed > > for that function and can be implemented as exported symbol. > > incline -> inline? Thanks > >