Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Jul 2021 11:06:24 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     David Laight <David.Laight@ACULAB.COM>
Cc:     Len Baker <len.baker@gmx.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Pavel Skripkin <paskripkin@gmail.com>,
        "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging/rtl8712: Remove all strcpy() uses in favor of
 strscpy()
Message-ID: <20210721080624.GV1931@kadam>
References: <20210717155145.15041-1-len.baker@gmx.com>
 <20210719053747.GN1931@kadam>
 <de94438319a84e0985b3ba0f5c00807b@AcuMS.aculab.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <de94438319a84e0985b3ba0f5c00807b@AcuMS.aculab.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNXP275CA0040.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:18::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Wed, 21 Jul 2021 08:06:36 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: eb117d54-c52d-4c8a-b44a-08d94c1e79bc
X-MS-TrafficTypeDiagnostic: MWHPR1001MB2398:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR1001MB2398958CE06E30A3892649A38EE39@MWHPR1001MB2398.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: yJqTjyUePPGSCfP28LUxTlPq5Eofa2yyy2n5YoRrGMGjiFXlyIoaqZHG5zFj0+2w2QgiVGsdIB5WHVicapM9jo3wWR6d5mrRQPqD7XavfsOxUAhP6/W6OUbYvc0XbT8oVM1Xcpx84GKZoO9OhZ9ESzXHNv7kxeG2DLjs43TkvntTe2p+BION9wd15er3wqc8po7nTtXcMcUuNAU6uBB+lSRmw+1Ma+PP3m7D4UW9HuJEtdI80GR8npgz3aU99OFyPX59GMpC2gx0XW19CjoCV1bXzxTJwdv/ecyIZrh6YUBLnbST8yc+dtrtf/Bh0DpJgNuOvR5YvwhHT1tr4omxhhTjJncb11JeNNAXNsg8ZfHdF8ASYSiLzAtsc9E1mmHkUwnITgubv9cKDCE6zd9AsLbJxMKf8Iqyq9A3ZiZQpKdVespWvBAWRPps+XtQAFpV89muPhl4QveJR8UyzmR2Gu8Y5QIsgN5QbbpJSXQDj8CnhhycvzJ+SPs2PGYH3JRPatSKUDihjXcsK6ML+RJ59yDgyHjq72/2Aa6OG+AsAeFoKtHYaxGHzDVKJS9MKHFXO9yq1mygdWdmoCWMHAa8y3PqwUaYc8OZIPXMCVptVu+m8wJNlgYG0XXsVsKJmH/lhOfiggyn5ZnsSitOOZy/uHFx8XWxNyPnuia6VN3w4R8s7zpx8BX4TzdYD9Md+iG+aBXwqyQSNqVzqHf20w7j5A==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(346002)(396003)(136003)(376002)(39860400002)(66946007)(956004)(66476007)(26005)(38100700002)(38350700002)(66556008)(83380400001)(1076003)(6666004)(33656002)(4326008)(54906003)(8676002)(316002)(6916009)(52116002)(9686003)(5660300002)(478600001)(44832011)(9576002)(4744005)(55016002)(86362001)(33716001)(8936002)(6496006)(2906002)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?61ZNeYTqc/rTR4oFG3S094iEZ8zA3NLCAy0YLQc1KcxmnWce+uyJIUycwseo?=
 =?us-ascii?Q?oPw40uMYlcVRvJ+Zy1H7lOl2YbL1iMi3IRRrGseONa9JBtBBhAP0VObR2QNd?=
 =?us-ascii?Q?aMIHmroqUgdG/NbDQNUEPIaJo5jgh+q218oWWhLtrReYRNAg1GlrFOpJhO4t?=
 =?us-ascii?Q?YU3y9DuTHkXpIBmgmG1tEm81e3x/wcKkqAiLFHuR0Dr4Iby2GrYskrcTs9Mm?=
 =?us-ascii?Q?Csgsv2DhnHvWALbusHTB13c1j+SdSmT0eJBigqC7BnSnSHbkmzwAED9hNWEe?=
 =?us-ascii?Q?a93hd989LOQStwvhsFheiUqE+MkN7KZYjY//TFnT5oLJDGDYM32GVQ+ShnaW?=
 =?us-ascii?Q?NFzX8wfYl+TzH7gVi9flRCIz7AKv/+EDClY6oFL99KmAWh3Gs56VoX7h5kWl?=
 =?us-ascii?Q?XC+QS9PNEOC8ouN24rTKXtwAUyyhJua6IICH8Tgu7Qf8ff+9q2tOotmFhG1V?=
 =?us-ascii?Q?2sfT781S1+iFLOvxqMEG8ZukJmKa1HSyDT1G63e9LE9qyKqhvck1Wd8NdhKR?=
 =?us-ascii?Q?nOqejjaPCseOG88Vklvlx+/aBX17Fz7gIhzOqlGlo8NIu9BuoqwLWF3MwuXo?=
 =?us-ascii?Q?nsk7e4r1bbhoEI49XUYR6U5EvzfmixcC14iNgiL//Kfh8tosDK4B9Us8w2P1?=
 =?us-ascii?Q?j7Hj0uUHZNfS5HyPB48twiVMg1+7z5Xaq9D3eseJWNlSXFzpDPInMiKbgOZH?=
 =?us-ascii?Q?ETrZUCa6jtypLAtuuyoxg4/OB+Tf2inYpfngnf5D83d+PCCFrHZwCkz1oJ/z?=
 =?us-ascii?Q?1F+jQ1jrAHrEcbzfSxQ+Iv3jatARUcBaqZ/Bj3uPt18IU1fAz+pF5jcYHRMR?=
 =?us-ascii?Q?YxoqhQcXc62qYvXivkjouGSTwLt0+AmcTs3Knv+svXlEcA3RiE3UiBrAIzCS?=
 =?us-ascii?Q?GU0kU+znIfsuW/f+/Qa14krt3NE9LAokcl7J4+rFpPFbUOg+6pzZyGvXNUBZ?=
 =?us-ascii?Q?WP4KgCQnSCOgi3n5R4PXI3FpWhSgeHy52l/CY26w1soYzPLr/7NfyoZUEiKf?=
 =?us-ascii?Q?H3MqVd6jRpxy+/cPDNxGZk0D7af7PJJ10WmR3O80hFOtcuOOmzf3TTroWTrb?=
 =?us-ascii?Q?gZsuQIa6OnDyrQUJwhhUikDwwLkHV8zZnvYoT2MxRZxKXhju2AmDc5EZ5kOo?=
 =?us-ascii?Q?ioxYDZRe+jxUsxiGrNx/omqB3N3vOI7marYZzv24aqWAgPODcfPU071Edb6T?=
 =?us-ascii?Q?LfTrpLM5iLWCTeZ6b0WxTKOKhbejPhi53c9DP3SC62iZZTtRWkafNvMcD7lO?=
 =?us-ascii?Q?57mQ0A7/nGOBlkRwZno1w/U+tRexDbyI6Ik+92iKHl1WO+nzsDnT0pgCDEvj?=
 =?us-ascii?Q?5dGq18D8ncO3zsjF+R7gpWji?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb117d54-c52d-4c8a-b44a-08d94c1e79bc
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2021 08:06:42.9243
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g8Blbw5rgPJ9nSLGEnG33fjTO2NVFsVH6ZRppDaRvDn6pcpfil5dASOxfncIaXd8FsZFswmArxIlh2Fskpfi/qXQztGUmEyvhKii3qGSnfo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2398
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10051 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 spamscore=0
 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107210044
X-Proofpoint-GUID: DkUtK1yTVrSL6xkDMelxnkIiQaFvfOAj
X-Proofpoint-ORIG-GUID: DkUtK1yTVrSL6xkDMelxnkIiQaFvfOAj
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 19, 2021 at 03:24:38PM +0000, David Laight wrote:
> From: Dan Carpenter
> > Sent: 19 July 2021 06:38
> ...
> > Not related to your patch but this code is bad.  What it does is the
> > "ifname" can be set as a module parameter.  So instead of testing if it
> > has been set, it uses the checking inside dev_alloc_name() to see if we
> > can allocate what the user requested.  If not then set it to "wlan%d".
> > If we cannot allocate what the user wants then we should return an
> > error.
> > 
> > It should do:
> > 
> > 	if (ifname[0] == '\0')
> > 		strscpy(ifname, "wlan%d", sizeof(ifname));
> > 
> > 	ret = dev_alloc_name(pnetdev, ifname);
> > 	if (ret < 0) {
> > 		dev_err(pnetdev, "allocating device name failed.\n");
> > 		return NULL;
> > 	}
> 
> I know only root can set module parameters, but having one
> that contains a string used as a printf format seems
> dangerous at best.
> 
> Isn't it best to let userspace rename the interfaces later on?

Yeah.  I think you're right.

regards,
dan carpenter