Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Jul 2021 10:16:14 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Phillip Potter <phil@philpotter.co.uk>
Cc:     Larry.Finger@lwfinger.net, dan.carpenter@oracle.com,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH resend] staging: rtl8188eu: move all source files from
 core subdirectory
Message-ID: <YPfXzlmYk4EPap+F@kroah.com>
References: <20210719224601.255364-1-phil@philpotter.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210719224601.255364-1-phil@philpotter.co.uk>
Precedence: bulk

On Mon, Jul 19, 2021 at 11:46:01PM +0100, Phillip Potter wrote:
> Move all C source files from the core subdirectory to the root
> folder of the driver, and adjust Makefile accordingly. The ultmate
> goal is to remove hal layer and fold its functionalty into the main
> sources. At this point, the distinction between hal and core will be
> meaningless, so this is the first step towards simplifying the file
> layout.
> 
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
>  drivers/staging/rtl8188eu/Makefile            | 34 +++++++++----------
>  drivers/staging/rtl8188eu/{core => }/rtw_ap.c |  0

<snip>

As others have pointed out, let's move files when they need to be moved,
not yet.  Removing the HAL layer is great here, but when that happens,
the hal/ directory will be empty and we can go from there if things
still need to be moved.

thanks,

greg k-h