Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Jul 2021 11:42:21 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Jean Delvare <jdelvare@suse.de>
Cc:     linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] i2c: parport: Switch to use
 module_parport_driver()
Message-ID: <YPfd7aJfvH+NYtl1@smile.fi.intel.com>
References: <20210712141119.22426-1-andriy.shevchenko@linux.intel.com>
 <20210721102146.66a486bc@endymion>
 <YPfc2eBjc4I2ycKV@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YPfc2eBjc4I2ycKV@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Jul 21, 2021 at 11:37:45AM +0300, Andy Shevchenko wrote:
> On Wed, Jul 21, 2021 at 10:21:46AM +0200, Jean Delvare wrote:
> > On Mon, 12 Jul 2021 17:11:19 +0300, Andy Shevchenko wrote:
> > > Switch to use module_parport_driver() to reduce boilerplate code.
> > 
> > This has the downside of moving the sanity check of the type parameter
> > to run time, instead of driver load time. In particular this means that
> > loading the i2c-parport driver without specifying the type will no
> > longer fail.
> 
> And this is actually an advantage of the change if you think about it.
> Now we can have a module that won't fail at boot time and give the user
> a chance to amend parameter at run time if it was wrong at boot time.

Okay, for built-in driver it might require to check and fix permissions
of the parameter sysfs node (currently 0).

> > The driver will load successfully, but won't do anything.
> > 
> > While I prefer user errors to be reported as soon as possible, I don't
> > really mind here, as parallel port drivers are not something worth
> > debating over at this point in time. As a matter of fact, I can't
> > possibly test this change as I no longer have a parallel port on any of
> > my systems.

-- 
With Best Regards,
Andy Shevchenko