Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5321729pxv; Wed, 21 Jul 2021 02:36:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMrYL4cqVy5yCkrwYNJ67Fyz/37HRy0qDcJXmbANHxMyABd86AN5SRwTqgkormxeq1Ojhx X-Received: by 2002:a92:c5c5:: with SMTP id s5mr22193222ilt.271.1626860163281; Wed, 21 Jul 2021 02:36:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626860163; cv=none; d=google.com; s=arc-20160816; b=SAcdQ33iKandn9pp4w+61ZkmaNaFjZZnc0Y5i6M68S4XNmt1ntXgkjhFfcZQD5p3cR zIj6B5eOubBXnymPd04LK9rRMU4D3LfVTcx92wsEMTX643zFUIUKsZTMQsdmKzcQD09m OyJaqjxXhE5D6uW/G9y4xsca/DlEDJjzxZC86YMcz62FN84EVt8clflHmGRfrJdJF7B7 cBbETIhfg5pbEShZ0n5U459IEYmguK+NRKHnXd3DnQPO6qlvYWW/c1SG41/7b23YqBqs 0ZRVkQr9+6Yny5OQDxTyy01qWENgZ+owdKplGQ/ZVWyg0kIMBnSoYX1YLQiVwCOSXgxp sJpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KPjK1ybRYHwXrr0XO80Y8uh5gj+2Ip9W4wgw+paFkB8=; b=vFI/tVGs9hmmFNcYum419c359bwE+KCzbHVEjyqDnxU8FYbWL2aAEppKYQfrogXxQ+ QDnOhWFdy6GZeF8PqiBu0ms7QxiGHHjCdUkeg5od+KTs3rYbMS1fFB47FbVaV4swKbfk Ean+rYBocN8UiTH3YJQcMzIdjDZdowj4dFfeM23HH27Z4+516wXESLia4Qf7VQl1GU/T qdqhuknLXlTqH6RcywyV1mSjNsNfrjZ5Bk05n91NaJ+Pb/91HkNa4TgAkQ3Akm5vnVI9 lIYHUVUqBmVnS9qRDpX9y7BWXZcUpn0gWFWTa2RX+feYuXWqbj3cokkjUHx+pwPVl3On 7M0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MFNEJy6+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d17si7374614ilf.150.2021.07.21.02.35.52; Wed, 21 Jul 2021 02:36:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MFNEJy6+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236680AbhGUIw1 (ORCPT + 99 others); Wed, 21 Jul 2021 04:52:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:60938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237977AbhGUIpO (ORCPT ); Wed, 21 Jul 2021 04:45:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E87DF60231; Wed, 21 Jul 2021 09:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626859549; bh=yOJ5z3dKNV3+QchjXIKT3u7IgTGFQKf/v3HEvGwojAg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MFNEJy6+0KDma+GVnPxoqHG/SyR6bZYdr9N5GCoasKKLZ+3ZRPnrhd7YAq4qBl9dj yA2/lEXl51QkqvB9u9xzEv/IWu1qDifBaCmFAyodadwkTn9nTK9WabCUlfoC4ae/ua MGg6tEJI1ZgD931V/EOFH/GTajj7ZchxM5NWUdpM= Date: Wed, 21 Jul 2021 11:25:47 +0200 From: Greg Kroah-Hartman To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Arnd Bergmann , Lee Jones , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v14 5/9] staging: hi6421-spmi-pmic: cleanup drvdata Message-ID: References: <723edefbb2e9ce0b70d9c7bce95f288e3ea1f5b1.1626515862.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <723edefbb2e9ce0b70d9c7bce95f288e3ea1f5b1.1626515862.git.mchehab+huawei@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 17, 2021 at 11:58:16AM +0200, Mauro Carvalho Chehab wrote: > There are lots of fields at struct hi6421_spmi_pmic that aren't > used. In a matter of fact, only regmap is needed. > > So, drop the struct as a hole, and set just the regmap as > the drvdata. > > While here, add a missing dot at the Huawei's copyrights. > > Acked-by: Mark Brown > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/misc/hi6421v600-irq.c | 9 ++++---- > drivers/regulator/hi6421v600-regulator.c | 10 ++++----- > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 16 +++++-------- > include/linux/mfd/hi6421-spmi-pmic.h | 25 --------------------- > 4 files changed, 14 insertions(+), 46 deletions(-) > delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h This patch fails to apply to my 5.14-rc2 tree, it gets a failure in the regulator portion of the patch. thanks, greg k-h