Date: Tue, 21 Nov 2006 21:06:22 +0000
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andi Kleen <ak@suse.de>, Adrian Bunk <bunk@stusta.de>,
       Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
       linux-kernel@vger.kernel.org, discuss@x86-64.org
Subject: Re: [2.6.19 patch] i386/x86_64: remove the unused
 EXPORT_SYMBOL(dump_trace)
Message-ID: <20061121210622.6cea428f@localhost.localdomain>
In-Reply-To: <20061121201844.GA7099@infradead.org>
References: <20061121194138.GF5200@stusta.de>
	<200611212047.30192.ak@suse.de>
	<20061121201844.GA7099@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1151
Lines: 28

On Tue, 21 Nov 2006 20:18:44 +0000
Christoph Hellwig <hch@infradead.org> wrote:

> On Tue, Nov 21, 2006 at 08:47:30PM +0100, Andi Kleen wrote:
> > On Tuesday 21 November 2006 20:41, Adrian Bunk wrote:
> > > This patch removes the unused EXPORT_SYMBOL(dump_trace) added on i386 
> > > and x86_64 in 2.6.19-rc.
> > > 
> > > By removing them before the final 2.6.19 we avoid the possibility of 
> > > people later whining that we removed exports they started using.
> > 
> > I exported it for systemtap so that they can stop using the broken
> > hack they currently use as unwinder.
> 
> Nack, dump_trace is nothing that should be export for broken out of tree
> junk.

It is exported for systemtap not random broken out of tree junk, and the
result is a good deal prettier. Systemtap guys really ought to get their
stuff merged too, although how we merge a dynamic module writing tool I'm
not so sure ?

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/