Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210717142513.5411-1-len.baker@gmx.com>
In-Reply-To: <20210717142513.5411-1-len.baker@gmx.com>
From:   Stanislav Yakovlev <stas.yakovlev@gmail.com>
Date:   Wed, 21 Jul 2021 14:20:45 +0400
Message-ID: <CA++WF2ON8E=FNHj3SqO=OMvx6SBB=Lv517rmCrBTvG+6d=tL3A@mail.gmail.com>
Subject: Re: [PATCH] ipw2x00: Use struct_size helper instead of open-coded arithmetic
To:     Len Baker <len.baker@gmx.com>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        wireless <linux-wireless@vger.kernel.org>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 17 Jul 2021 at 18:25, Len Baker <len.baker@gmx.com> wrote:
>
> Dynamic size calculations (especially multiplication) should not be
> performed in memory allocator function arguments due to the risk of them
> overflowing. This could lead to values wrapping around and a smaller
> allocation being made than the caller was expecting. Using those
> allocations could lead to linear overflows of heap memory and other
> misbehaviors.
>
> To avoid this scenario, use the struct_size helper.
>
> Signed-off-by: Len Baker <len.baker@gmx.com>
> ---
>  drivers/net/wireless/intel/ipw2x00/libipw_tx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Looks fine, thanks!

Stanislav.