Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5416288pxv; Wed, 21 Jul 2021 05:05:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfcT3/iCkf1wq5cemyRKaFnYAEkEQ793qv1GNrTE35shd1XoqLHGoijZRFgaLIGsnbHrpT X-Received: by 2002:a50:ee15:: with SMTP id g21mr47184458eds.334.1626869148652; Wed, 21 Jul 2021 05:05:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626869148; cv=none; d=google.com; s=arc-20160816; b=CS2HDNWT1XYyclNTOxsiRMATPzCdTV9zF7SOyQBQxAR43kMeHz1rArtxiB6UM235uM gY5J1ctKQta7vUKNGzZQGBig4ohtDnPjwC4DFjJGBPfe22a80zEVk3WPp0FOM3oIgwpv ny9WHZb8i2cv6C7lYnvjVczeU2F7iKzuLtaexGorHsUUQjhOlQpdW44yLO4nSZdyhF8H us/t4HmjuJEV1ocCnFFLuUQPWNuCW/OeqbsMmZxHBws01CWqz3MwAlRyif3HF6gOPiHe Q75FOIgGrDDZrNg5al3Nkp6JPSxyjmVuP2OOu34oGsBjCaE1RBAzj4PHKwX2v5eJFoXE erpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:subject:from :references:cc:to:dkim-signature; bh=1aayxhP7LR5pbpYNWPExB3m6iym6gHf5XQMlRKlxp94=; b=eraCeujxQqdWxpP62MFoSOxO7fz+etepL0LOjE+2mJhmEIvSZccZ2sVcmpTmrZqBVD wwysEfAnvNGTP89Aod8aTF9Ob0MDDiugYaj6vWANLITFjV564BpAwhIpTqzzVbcxGuQW ZlEkUXDSbAahdgZfX/BaDqOsypI1SJAUdd1VkNmSc33WqFFsbexDvIGD/OqBkUQ0Txl1 7rMv6yU583Zum6EX7e2ElbjoOZWKji6o4frdl1xJxHXD7NMZVdohCl4NXUrZyT0bAeAk zbcibrIapuAmlLVsrS7t+lV23ljXQDdTcY7ezK65OjNCeU2gf6t1RxCJnxGvCNM8UbTb etfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Gb3sYMtx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ox14si27528434ejb.694.2021.07.21.05.05.24; Wed, 21 Jul 2021 05:05:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Gb3sYMtx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236564AbhGULXQ (ORCPT + 99 others); Wed, 21 Jul 2021 07:23:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238612AbhGULRQ (ORCPT ); Wed, 21 Jul 2021 07:17:16 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09B08C0613F0; Wed, 21 Jul 2021 04:57:15 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id r21so1604708pgv.13; Wed, 21 Jul 2021 04:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1aayxhP7LR5pbpYNWPExB3m6iym6gHf5XQMlRKlxp94=; b=Gb3sYMtxc/kWDCMnCmYUN5o70Tvt9W/hvjABaQVw6GepiW6AF7jJcANbzNBRV1gq0H KVgsqId2MY+RXzDpDGY6dPw0M9zOWZUAQNGPy7PM2rys/HzrGgdYJ1JWxUE1QI9btZVV O6Nge5AQbsqTmzXcQomJIje10kgbOVDLOw6CAEgavNSXA2gO45gvZInn+kY7JYMZv+qO 7oKYPWFeZHS6IplBXQIb7MGoEHkzU7p7v5SEAUS6Qb0XpyY5ciKG5wbqqw5mBV2thXmN kc5wkdciG83RddYCL0ig7AXvXY6vLlAn6fNTtakKWWWjb2B/kLBoNRRLEWJHhmSw7M5h laRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1aayxhP7LR5pbpYNWPExB3m6iym6gHf5XQMlRKlxp94=; b=uJEdn8tjxHhJCruSReDaV0ZOgAvLnu9yr9M4loyMMjVorvNRI0CYggM0nItHGV/y4v fieSuGoLFpwDT/XXuS+gM64Sjj0W6AT5HzwrX5Ph0y7uv3PDcgLT7PLn6tZJVll5MGVN yFpU9xFiWxc5uFdr6rDxXqPFTVigl6yPKDvLp+s84o2uk6AYbXAsy45gr3OG6doqqLu0 DrpvWLutgCnYfW50E/71xlc5Jj+GljbnAHdkxKsPZ924ifcjGuJ+IjRAfwGqCS+dElAA B+Sp4menyDj3PuG6tPvkbLsTyvNjXT9vq5CBuKjC883hThd2b6/yTQ8dxca48gHY6Ifh LV3Q== X-Gm-Message-State: AOAM532FYp72Pa9LPt1LJFVv3hWiXCVJRtTJ2D8LnsQ3tTnqiaOlNSnA MN8mlY8IECGg3QQjRsIPyyQ= X-Received: by 2002:a63:a01:: with SMTP id 1mr35267098pgk.360.1626868633306; Wed, 21 Jul 2021 04:57:13 -0700 (PDT) Received: from Likes-MacBook-Pro.local ([103.7.29.32]) by smtp.gmail.com with ESMTPSA id j12sm25930570pfj.208.2021.07.21.04.57.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jul 2021 04:57:12 -0700 (PDT) To: Zhu Lingshan Cc: bp@alien8.de, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, kan.liang@linux.intel.com, ak@linux.intel.com, wei.w.wang@intel.com, eranian@google.com, liuxiangdong5@huawei.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, boris.ostrvsky@oracle.com, Like Xu , Will Deacon , Marc Zyngier , Guo Ren , Nick Hu , Paul Walmsley , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, xen-devel@lists.xenproject.org, Peter Zijlstra , Paolo Bonzini References: <20210716085325.10300-1-lingshan.zhu@intel.com> <20210716085325.10300-2-lingshan.zhu@intel.com> From: Like Xu Subject: Re: [PATCH V8 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks Message-ID: Date: Wed, 21 Jul 2021 19:57:01 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210716085325.10300-2-lingshan.zhu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/7/2021 4:53 pm, Zhu Lingshan wrote: > + } else if (xenpmu_data->pmu.r.regs.cpl & 3) Lingshan, serious for this version ? arch/x86/xen/pmu.c:438:9: error: expected identifier or ‘(’ before ‘return’ 438 | return state; | ^~~~~~ arch/x86/xen/pmu.c:439:1: error: expected identifier or ‘(’ before ‘}’ token 439 | } | ^ arch/x86/xen/pmu.c: In function ‘xen_guest_state’: arch/x86/xen/pmu.c:436:9: error: control reaches end of non-void function [-Werror=return-type] 436 | } | ^ cc1: some warnings being treated as errors > + state |= PERF_GUEST_USER; > }