Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 21 Jul 2021 14:00:36 +0200
From:   Johan Hovold <johan@kernel.org>
To:     Dongliang Mu <mudongliangabcd@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>, stable@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@suse.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty: nozomi: tty_unregister_device ->
 tty_port_unregister_device
Message-ID: <YPgMZBK/FWLRD1Ic@hovoldconsulting.com>
References: <20210721113305.1524059-1-mudongliangabcd@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210721113305.1524059-1-mudongliangabcd@gmail.com>
Precedence: bulk

On Wed, Jul 21, 2021 at 07:33:04PM +0800, Dongliang Mu wrote:
> The pairwise api invocation of tty_port_register_device should be
> tty_port_unregister_device, other than tty_unregister_device.

Are you sure about that? Please explain why you think this to be the
case and why this change is needed.

> Fixes: a6afd9f3e819 ("tty: move a number of tty drivers from drivers/char/ to drivers/tty/")

Please try a little harder, that's clearly not the commit that changed
to the port registration helper.

> Cc: stable@vger.kernel.org

Why do you think this is stable material? (hint: it is not)

> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
>  drivers/tty/nozomi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
> index 0c80f25c8c3d..08bdd82f60b5 100644
> --- a/drivers/tty/nozomi.c
> +++ b/drivers/tty/nozomi.c
> @@ -1417,7 +1417,8 @@ static int nozomi_card_init(struct pci_dev *pdev,
>  
>  err_free_tty:
>  	for (i--; i >= 0; i--) {
> -		tty_unregister_device(ntty_driver, dc->index_start + i);
> +		tty_port_unregister_device(&dc->port[i].port, ntty_driver,
> +				dc->index_start + i);
>  		tty_port_destroy(&dc->port[i].port);
>  	}
>  	free_irq(pdev->irq, dc);

Johan