Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5703034pxv; Wed, 21 Jul 2021 11:44:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXUJPJITyn8eAXzHDjQdiPKO65BxvFUyj3+Hsf1HAbT3juqQuML1pPS3ql5zTdh9zXGlaj X-Received: by 2002:a05:6402:4cb:: with SMTP id n11mr49335088edw.292.1626893082083; Wed, 21 Jul 2021 11:44:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626893082; cv=none; d=google.com; s=arc-20160816; b=wU7CYsVnDgNL0yC48zzPuHu6T5+ud6HbcOsJ0TUJYxiavF7N/tduHYRluMj0r3eS0R yM0UXbN3id3ovhD4nQZZiF/6mB6uNapW+29tcZew094pAFAtvS5fVG15je8G16CIinSr o71hLeKr0I5kLofDSB88yfiqZmu4/4f9GTNYH67eKdbDd39Uc6D3i3+2zQLBJf/pDj10 +Yw8MNftAGZFBSEKMgRXn+O92ljMMJXKk+Mq46fUIQ+o34hq4sCoHXEFbaSb7jENUVp4 RHACpPpCh5IDuq/jobkz9PC0IZJsC1IrLORV3LeYUf1S2mcUFrTFWRGogvjvJwZlsBtJ q9ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=+7Qp3N8i2ZqaUKiDMln9kfRvQQx8iZ4aXJx31dGT4ps=; b=wFn33nR2/VYGKGt9cTQsrWtRb/mtR04XrtfgsAf9meRP1kyveorxJEvWr7awQKaxYd c2pRwZZ/vorSo3cjUDTGuHFJmjdemRmHNTJSTwVQYpUyLW8J56TUBQt6m7QK9icRwmOx 8T5/MB3lcDOMQQfQxrZKL539tmpcsgEDi6oRhaESi2FO2DaLgtnIT3l9s4jlGDR6sRg2 aA+FoRORYp4vZmC0u8Qw1xOrqjDWDcAo/dX4JNoc1eApxmgYjV7FEirZLDbzhjO5DoFg Adwm0Bq8X1YDgHgw6QQ2/3961BtI4HTc5UTMOU3Fxaj0WNvxxfYk7mCj4rwBTwQ//GND ZU3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=k+zdBVlI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k5si28550749ejv.445.2021.07.21.11.44.17; Wed, 21 Jul 2021 11:44:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=k+zdBVlI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237974AbhGUNWR (ORCPT + 99 others); Wed, 21 Jul 2021 09:22:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237641AbhGUNWQ (ORCPT ); Wed, 21 Jul 2021 09:22:16 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20928C061575 for ; Wed, 21 Jul 2021 07:02:53 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id a12so3312983lfb.7 for ; Wed, 21 Jul 2021 07:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+7Qp3N8i2ZqaUKiDMln9kfRvQQx8iZ4aXJx31dGT4ps=; b=k+zdBVlIlSQR1P9SUQm4rWxiuVKGt+Rdrj1zn8ykerQwuV2c1ohdgP/tbToleYU5pK k6tkA3Mffh6O0IrtAKFfYHwFBINE6YXJlCMzAycKnlMV7qsU8JoUvPTK5RHN4JsRuMWN nx9VIsMrsX8K39QuvUjj/Kf2qwdLWVwkPiBtrLkhsmIVin8FOcccA7I4rp3fRqeqOadM crhsm3N2Fj9J1rz1Pn0Yzid3rVP0rk8uousrwvM5nCE4hVwHDql8jShpAWYHQ3qPoYd3 deHr+L3O/Ay9z5Hl+PQ9IMMgY0dpBiyHYDwVn6AyxH2f2nROXplKiAaKTpHL3jzElEg9 jtPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+7Qp3N8i2ZqaUKiDMln9kfRvQQx8iZ4aXJx31dGT4ps=; b=XFQiZI/IOPgK2NqXPu71mIiTdtLVEqEZOo3ajMGFUbuAu5TBarDqg+EjvAyd/xATwf LanO42mU0rGNr2SCDM11JN9oqHXk3AliJ9KjaszZ4TcAN2Py21LTyyUsleUJKoeLyP4+ UbK+NmQ8TqOnDEYRB43Egr67GdFgd0Bo9PN5z5QcYrPuum3nT8lbJTP25RtcfNnyqj2E 5VIIC8lZDwBZqAgO25750amABh2Rme1YKzSPzzTMc6FiyQyEJbCw07e5WvB9g/ZPKCZa xETae5RK0W+V6yM+nc+BkvEkd2wlVJdDMu9h9vGmvEm6dHwWJT8f+FP0xDt2v0MGtmRb viYg== X-Gm-Message-State: AOAM530pqKiOImHtPjVW15k5vYzhOPfeoeLlrSaGoPYpDGZr8rbfIYzx i5w7APlInsc6UpvHZmSt947cpbN9sazzDAK0yJuodg== X-Received: by 2002:ac2:5e71:: with SMTP id a17mr25038632lfr.465.1626876169985; Wed, 21 Jul 2021 07:02:49 -0700 (PDT) MIME-Version: 1.0 References: <1626853288-31223-1-git-send-email-dillon.minfei@gmail.com> <1626853288-31223-4-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1626853288-31223-4-git-send-email-dillon.minfei@gmail.com> From: Linus Walleij Date: Wed, 21 Jul 2021 16:02:39 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver To: dillon min Cc: "thierry.reding@gmail.com" , Sam Ravnborg , Dave Airlie , Daniel Vetter , Rob Herring , Alexandre Torgue , Maxime Coquelin , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Doug Anderson , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 21, 2021 at 9:41 AM wrote: > From: Dillon Min > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > with mipi_dpi_interface driver, can support ili9341 with serial > mode or parallel rgb interface mode by register configuration. > > Cc: Linus Walleij > Signed-off-by: Dillon Min > --- > changes in v2: > - replace vcc regulator to three bulk regulators(vci, vddi, vddi-led) > according to linus suggestion, thanks. This is a really nice driver. Reviewed-by: Linus Walleij Yours, Linus Walleij