Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5704066pxv; Wed, 21 Jul 2021 11:46:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjPc8vWvUD3Oy8MckDijslEFahIm0Cf7VcebSFdBMyjLdkq6qnZA6xrELTuHYgiey6eWV5 X-Received: by 2002:aa7:de92:: with SMTP id j18mr19294261edv.141.1626893203242; Wed, 21 Jul 2021 11:46:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626893203; cv=none; d=google.com; s=arc-20160816; b=h/gpjQmtFW80RkCcaB/MIwvL5PF0A03zHGUUlu/qPt55DnwL3zpESpIkf4ND2QcKWu qjWFBc0lTXgCSNibGK7SX38LS1TI32ceY3jFC03ebrqibTvJXqoPrZfF91P3n55xCUaZ GP3fqqzbREO6tMyghF5zBlJt3o5I12PLIv//eoTqBkwT7Bkf2lhYrIMLnqWCMu6YOtB3 5RFTZPXveGWCaQLtaNmg3O7xMAYRENEQLw2fZnwdJmbRkRMa4Q0BifEJIPCR1R/y4X0t yAJHTIG3dtfmNqjGaysf073DVLsRg4pOw4CEfIRnUyR4pgGNe4EHNdSncVxsv3n4RFNm vS+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=+cGFAAgYbKbT/oKXMw/ioitanAoRkhilVXc2hZdhdW8=; b=SPfSZ27kiScz6oymZEWoddGLp0jKwNEqVDOCUG/dfdI6WLaAerAnQqT/kUTy62qcsY 5jaeeoOoZezYak1WAYD0AA/EoG9QNvsB1CqC74f2MXqHLUggRwAgemKsoCDuT9wNBZ9o Jp4Q02htpIj5cnoYl23ASze5y3nKTYQXAkkkcZ61C7nSVjnug/h08nbW1AgAM/RRvdxT 85FVqNnTJFKionNxh7Yc3uLscEud9BCr1zAzlNQ/0MHIrupXk8m7VqtbHWkPfzxFSNFJ 9u4hpazYMQnB87+Io+oWh81JAjb1p9llTS0ldaSG6OrAvJXJgyAluztpxVD/bs/Hmyg0 HPcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=RgDS4OQ+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u5si24108897ejr.382.2021.07.21.11.46.19; Wed, 21 Jul 2021 11:46:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=RgDS4OQ+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237539AbhGUNbG (ORCPT + 99 others); Wed, 21 Jul 2021 09:31:06 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:53570 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232079AbhGUNbF (ORCPT ); Wed, 21 Jul 2021 09:31:05 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 8B66C2034F; Wed, 21 Jul 2021 14:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1626876701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+cGFAAgYbKbT/oKXMw/ioitanAoRkhilVXc2hZdhdW8=; b=RgDS4OQ+hznjaeTtYSs1ZNgR+KxBce/K5tVZmU7qSR5FpMrQihjiBojlwE6X7X38abCWNT pHCyD0yayR9+4TYtX/5jX5vOSMIYaVwFjLvYpPC91NII6c9aB81YKg1NXCYER8zSFmp9CQ IE5u31TlViWbyfdfL9mk8u2Mz67VUUk= Received: from suse.cz (pathway.suse.cz [10.100.12.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 75FC2A3B8A; Wed, 21 Jul 2021 14:11:41 +0000 (UTC) Date: Wed, 21 Jul 2021 16:11:41 +0200 From: Petr Mladek To: Jia He , Alexander Viro Cc: Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Jonathan Corbet , Linus Torvalds , "Peter Zijlstra (Intel)" , Eric Biggers , "Ahmed S. Darwish" , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox , Christoph Hellwig , nd@arm.com Subject: Re: [PATCH v7 0/5] make '%pD' print the full path of file Message-ID: <20210721141141.ehnnneafnwezqnk6@pathway.suse.cz> References: <20210715011407.7449-1-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715011407.7449-1-justin.he@arm.com> User-Agent: NeoMutt/20170912 (1.9.0) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2021-07-15 09:14:02, Jia He wrote: > Background > ========== > Linus suggested printing the full path of file instead of printing > the components as '%pd'. > > Typically, there is no need for printk specifiers to take any real locks > (ie mount_lock or rename_lock). So I introduce a new helper > d_path_unsafe() which is similar to d_path() except it doesn't take any > seqlock/spinlock. > > TODO > ==== > I plan to do the followup work after '%pD' behavior is changed. > - s390/hmcdrv: remove the redundant directory path in printing string. > - fs/iomap: simplify the iomap_swapfile_fail() with '%pD'. > - simplify the string printing when file_path() is invoked(in some > cases, not all). > - change the previous '%pD[2,3,4]' to '%pD' > > Jia He (4): > d_path: fix Kernel doc validator complaints > d_path: introduce helper d_path_unsafe() > lib/vsprintf.c: make '%pD' print the full path of file > lib/test_printf.c: add test cases for '%pD' > > Rasmus Villemoes (1): > lib/test_printf.c: split write-beyond-buffer check in two The patchset is ready for linux-next from my POV. I could take it via printk tree if Al provides Acks for the first two "d_path: *: patches. Or Al could take it via his tree if he would prefer to do so. Best Regards, Petr