Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5706178pxv; Wed, 21 Jul 2021 11:50:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4Qus3+LReRoPgklMZ8+SBkW4Syy1prPt6lghOswc8fn9ftIitgD76I3K+1awf0FmD7h40 X-Received: by 2002:a05:6638:3887:: with SMTP id b7mr30520401jav.42.1626893431264; Wed, 21 Jul 2021 11:50:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626893431; cv=none; d=google.com; s=arc-20160816; b=u/GKxwXsYVx5UXfSx6U+beSHejBJr3BUoKN4znRKEXcnvKpS7cCiqmleiWUo9YwY53 USBLeNwqG2YUcUt+Zjn1jtaIBcXgbYo78OYSKTtzaN9ONlDe//jpGp0F6Ux6OAaIR9wT rCwrKM1lQtXSS2+LKTdyDUwVtwz2WQyW4Ac7mWLmsaQos7r5tdnxlwdbJr44KlHXMQej eOAwG/kxMXTlht1K5sEPx5mLN0UQfNvaNWg1aTx6FK1sFi/aJpZd2fJuO26otevH8rP3 sr28doAvn4wgFR51hLyWPqscL6OnNN2dsW2wXl4OWzlgh8T89fe+deOYjHjavdtcdIPk JGGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=1wkW6DImIBND/47htNy/ePiwKowv2fAiCrDFUOz0Z3M=; b=oW64ZAQr43PuxgYSC+4Uq8wuFBMLhyGhY1YGKxtsMb0mnxWrtAdOCXLKckLY6oJ/Km fR0dVk/dcK7pK74rzoid+CSiBJTERBoJJ5HJKFwXqr9hQt3tZgX1lss8bZkggBpne5O8 Tr2aGuvOpfl9zwgc3kg3zCxr3wWPwXJrNMgM+Z3nsIMgbdwRi9QH8Da+at6dWeiCROgO RV48mKrpRlfYoybxHSBO3o/KP2kibDOUms28776mbYGedopcIpJgW8Uq6plUa1LMAG21 Xck0DWX022zWaEIisf5Qm452NU5+jRBgBMfSlY+h8nt6/IJMhFMa3iYGm29D32Bta/m9 qxXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v10si9454097ilh.117.2021.07.21.11.50.19; Wed, 21 Jul 2021 11:50:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238925AbhGUNjy (ORCPT + 99 others); Wed, 21 Jul 2021 09:39:54 -0400 Received: from 8bytes.org ([81.169.241.247]:43038 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232419AbhGUNjx (ORCPT ); Wed, 21 Jul 2021 09:39:53 -0400 Received: from cap.home.8bytes.org (p4ff2b1ea.dip0.t-ipconnect.de [79.242.177.234]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by theia.8bytes.org (Postfix) with ESMTPSA id BC9EF87B; Wed, 21 Jul 2021 16:20:22 +0200 (CEST) From: Joerg Roedel To: x86@kernel.org, Eric Biederman Cc: kexec@lists.infradead.org, Joerg Roedel , hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , Kees Cook , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Mike Stunes , Sean Christopherson , Martin Radev , Arvind Sankar , Joerg Roedel , linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: [PATCH 00/12] x86/sev: KEXEC/KDUMP support for SEV-ES guests Date: Wed, 21 Jul 2021 16:20:03 +0200 Message-Id: <20210721142015.1401-1-joro@8bytes.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joerg Roedel Hi, here are changes to enable kexec/kdump in SEV-ES guests. The biggest problem for supporting kexec/kdump under SEV-ES is to find a way to hand the non-boot CPUs (APs) from one kernel to another. Without SEV-ES the first kernel parks the CPUs in a HLT loop until they get reset by the kexec'ed kernel via an INIT-SIPI-SIPI sequence. For virtual machines the CPU reset is emulated by the hypervisor, which sets the vCPU registers back to reset state. This does not work under SEV-ES, because the hypervisor has no access to the vCPU registers and can't make modifications to them. So an SEV-ES guest needs to reset the vCPU itself and park it using the AP-reset-hold protocol. Upon wakeup the guest needs to jump to real-mode and to the reset-vector configured in the AP-Jump-Table. The code to do this is the main part of this patch-set. It works by placing code on the AP Jump-Table page itself to park the vCPU and for jumping to the reset vector upon wakeup. The code on the AP Jump Table runs in 16-bit protected mode with segment base set to the beginning of the page. The AP Jump-Table is usually not within the first 1MB of memory, so the code can't run in real-mode. The AP Jump-Table is the best place to put the parking code, because the memory is owned, but read-only by the firmware and writeable by the OS. Only the first 4 bytes are used for the reset-vector, leaving the rest of the page for code/data/stack to park a vCPU. The code can't be in kernel memory because by the time the vCPU wakes up the memory will be owned by the new kernel, which might have overwritten it already. The other patches add initial GHCB Version 2 protocol support, because kexec/kdump need the MSR-based (without a GHCB) AP-reset-hold VMGEXT, which is a GHCB protocol version 2 feature. The kexec'ed kernel is also entered via the decompressor and needs MMIO support there, so this patch-set also adds MMIO #VC support to the decompressor and support for handling CLFLUSH instructions. Finally there is also code to disable kexec/kdump support at runtime when the environment does not support it (e.g. no GHCB protocol version 2 support or AP Jump Table over 4GB). The diffstat looks big, but most of it is moving code for MMIO #VC support around to make it available to the decompressor. Known problems: It currently only works reliable when the kexec_file syscall is used. With the kexec syscall it works one time, and the second kexec then hangs because the sha256 verification fails in the purgatory. For the kexec syscall the purgatory is loaded from user-space, were most likely the issue needs to be fixed. But the question is whether this is a useful way. The user-space purgatory has other ways to break under SEV-ES, which can be enabled via kexec-tool command line options. For example enabling console support for the purgatory will definitly break kexec for SEV-ES. So the question is whether is makes sense to only support kexec_file() under SEV-ES, where the in-kernel purgatory is used (which has less ways to break under SEV-ES). With that said, please review :) Regards, Joerg Joerg Roedel (12): kexec: Allow architecture code to opt-out at runtime x86/kexec/64: Forbid kexec when running as an SEV-ES guest x86/sev: Save and print negotiated GHCB protocol version x86/sev: Do not hardcode GHCB protocol version x86/sev: Use GHCB protocol version 2 if supported x86/sev: Cache AP Jump Table Address x86/sev: Setup code to park APs in the AP Jump Table x86/sev: Park APs on AP Jump Table with GHCB protocol version 2 x86/sev: Use AP Jump Table blob to stop CPU x86/sev: Add MMIO handling support to boot/compressed/ code x86/sev: Handle CLFLUSH MMIO events x86/sev: Support kexec under SEV-ES with AP Jump Table blob arch/x86/boot/compressed/sev.c | 56 +- arch/x86/include/asm/realmode.h | 5 + arch/x86/include/asm/sev-ap-jumptable.h | 25 + arch/x86/include/asm/sev.h | 13 +- arch/x86/kernel/machine_kexec_64.c | 12 + arch/x86/kernel/process.c | 8 + arch/x86/kernel/sev-shared.c | 333 +++++++++- arch/x86/kernel/sev.c | 494 ++++++--------- arch/x86/lib/insn-eval-shared.c | 805 ++++++++++++++++++++++++ arch/x86/lib/insn-eval.c | 802 +---------------------- arch/x86/realmode/Makefile | 9 +- arch/x86/realmode/rm/Makefile | 11 +- arch/x86/realmode/rm/header.S | 3 + arch/x86/realmode/rm/sev_ap_park.S | 89 +++ arch/x86/realmode/rmpiggy.S | 6 + arch/x86/realmode/sev/Makefile | 41 ++ arch/x86/realmode/sev/ap_jump_table.S | 130 ++++ arch/x86/realmode/sev/ap_jump_table.lds | 24 + include/linux/kexec.h | 1 + kernel/kexec.c | 14 + kernel/kexec_file.c | 9 + 21 files changed, 1764 insertions(+), 1126 deletions(-) create mode 100644 arch/x86/include/asm/sev-ap-jumptable.h create mode 100644 arch/x86/lib/insn-eval-shared.c create mode 100644 arch/x86/realmode/rm/sev_ap_park.S create mode 100644 arch/x86/realmode/sev/Makefile create mode 100644 arch/x86/realmode/sev/ap_jump_table.S create mode 100644 arch/x86/realmode/sev/ap_jump_table.lds base-commit: 2734d6c1b1a089fb593ef6a23d4b70903526fe0c -- 2.31.1