Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp5708933pxv; Wed, 21 Jul 2021 11:56:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfQH2iWIMbb6C7lJZC+5W3pvtbrnJqcwWivPx/RJ6nF9pLQriE2EjXKk4YSuHgt0VNM7Qx X-Received: by 2002:a17:906:d10c:: with SMTP id b12mr39150209ejz.395.1626893771041; Wed, 21 Jul 2021 11:56:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626893771; cv=none; d=google.com; s=arc-20160816; b=nELzIliwhrbKuPSkg4RJUBmKWwwUpFjf44Q6Km4OZaEzI50wl/W7AnPPyReVoRKf/p xA7QOaiAG2KDwDQFYui8qj/MfWIcX4bq2oi7tXetAMcP/ruJ+4c30o77cYxPf2hccRQG Wnkx0m8FoxO+FmdyElHFMyMhsn1oybDoTK+8Zar62fXhyCWCEx5KANcBF46fDIbTzsEG RlakbdYeVqfmUDWe5aVoliOfuyOT7j/ggKse/Ys7zqkyj8ZEZ23ZTdJJHwrE9USfCXp9 VqqSDGIYPqxC3fvJJJnerPCFm5VAsi04P4Pv5FJX4v/NFIWD5bL0k/1GgXKUBi75c+lB OknQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zeyDaCK5Pd9gOhlkaEW61YsowsVj0rgao0ng5fgpfY0=; b=SHvHrJ5Lh+KOWG4+7OLgiN7MJsoavJMtQR/co6/aL0EzhqAwa+6/ET4QTl5uRVZS1t 8M1e+5F2oxef24mEKx3OOu8FMmb418MeJtH5Lz7vjbYT5zB3jQvPSdLyZhI+DNrGYurH gn2xjrsyx3zzUWXl2Zt2NtO+vikJNJWjDXz+Ot+tyb4W0g0Yw5bCtGLdBmEjterqn4Lz mXcgo9QLcBAHebWQScJS5ECe1i0oi+0w6QWA1RmIf9JElx6Dar1GTtdvDs3Kd7aMDBsI OlvXpgltAYPIE/yPyIN2p3QWGeEGTyqpD+IpHCafdS2PPrt3A5IzecjFwVey/4AVzVGk tinQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v4si26999191ejv.698.2021.07.21.11.55.47; Wed, 21 Jul 2021 11:56:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239245AbhGUNkQ (ORCPT + 99 others); Wed, 21 Jul 2021 09:40:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239179AbhGUNkE (ORCPT ); Wed, 21 Jul 2021 09:40:04 -0400 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0D27C061757; Wed, 21 Jul 2021 07:20:40 -0700 (PDT) Received: from cap.home.8bytes.org (p4ff2b1ea.dip0.t-ipconnect.de [79.242.177.234]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by theia.8bytes.org (Postfix) with ESMTPSA id C917F99D; Wed, 21 Jul 2021 16:20:25 +0200 (CEST) From: Joerg Roedel To: x86@kernel.org, Eric Biederman Cc: kexec@lists.infradead.org, Joerg Roedel , hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , Kees Cook , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Mike Stunes , Sean Christopherson , Martin Radev , Arvind Sankar , Joerg Roedel , linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: [PATCH 03/12] x86/sev: Save and print negotiated GHCB protocol version Date: Wed, 21 Jul 2021 16:20:06 +0200 Message-Id: <20210721142015.1401-4-joro@8bytes.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210721142015.1401-1-joro@8bytes.org> References: <20210721142015.1401-1-joro@8bytes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joerg Roedel Save the results of the GHCB protocol negotiation into a data structure and print information about versions supported and used to the kernel log. Signed-off-by: Joerg Roedel --- arch/x86/boot/compressed/sev.c | 2 +- arch/x86/kernel/sev-shared.c | 22 +++++++++++++++++++++- arch/x86/kernel/sev.c | 13 ++++++++++++- 3 files changed, 34 insertions(+), 3 deletions(-) diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c index 670e998fe930..1a2e49730f8b 100644 --- a/arch/x86/boot/compressed/sev.c +++ b/arch/x86/boot/compressed/sev.c @@ -121,7 +121,7 @@ static enum es_result vc_read_mem(struct es_em_ctxt *ctxt, static bool early_setup_sev_es(void) { - if (!sev_es_negotiate_protocol()) + if (!sev_es_negotiate_protocol(NULL)) sev_es_terminate(GHCB_SEV_ES_REASON_PROTOCOL_UNSUPPORTED); if (set_page_decrypted((unsigned long)&boot_ghcb_page)) diff --git a/arch/x86/kernel/sev-shared.c b/arch/x86/kernel/sev-shared.c index 9f90f460a28c..73eeb5897d16 100644 --- a/arch/x86/kernel/sev-shared.c +++ b/arch/x86/kernel/sev-shared.c @@ -14,6 +14,20 @@ #define has_cpuflag(f) boot_cpu_has(f) #endif +/* + * struct sev_ghcb_protocol_info - Used to return GHCB protocol + * negotiation details. + * + * @hv_proto_min: Minimum GHCB protocol version supported by Hypervisor + * @hv_proto_max: Maximum GHCB protocol version supported by Hypervisor + * @vm_proto: Protocol version the VM (this kernel) will use + */ +struct sev_ghcb_protocol_info { + unsigned int hv_proto_min; + unsigned int hv_proto_max; + unsigned int vm_proto; +}; + static bool __init sev_es_check_cpu_features(void) { if (!has_cpuflag(X86_FEATURE_RDRAND)) { @@ -42,7 +56,7 @@ static void __noreturn sev_es_terminate(unsigned int reason) asm volatile("hlt\n" : : : "memory"); } -static bool sev_es_negotiate_protocol(void) +static bool sev_es_negotiate_protocol(struct sev_ghcb_protocol_info *info) { u64 val; @@ -58,6 +72,12 @@ static bool sev_es_negotiate_protocol(void) GHCB_MSR_PROTO_MIN(val) > GHCB_PROTO_OUR) return false; + if (info) { + info->hv_proto_min = GHCB_MSR_PROTO_MIN(val); + info->hv_proto_max = GHCB_MSR_PROTO_MAX(val); + info->vm_proto = GHCB_PROTO_OUR; + } + return true; } diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c index a6895e440bc3..8084bfd7cce1 100644 --- a/arch/x86/kernel/sev.c +++ b/arch/x86/kernel/sev.c @@ -495,6 +495,9 @@ static enum es_result vc_slow_virt_to_phys(struct ghcb *ghcb, struct es_em_ctxt /* Include code shared with pre-decompression boot stage */ #include "sev-shared.c" +/* Negotiated GHCB protocol version */ +static struct sev_ghcb_protocol_info ghcb_protocol_info __ro_after_init; + static noinstr void __sev_put_ghcb(struct ghcb_state *state) { struct sev_es_runtime_data *data; @@ -665,7 +668,7 @@ static enum es_result vc_handle_msr(struct ghcb *ghcb, struct es_em_ctxt *ctxt) static bool __init sev_es_setup_ghcb(void) { /* First make sure the hypervisor talks a supported protocol. */ - if (!sev_es_negotiate_protocol()) + if (!sev_es_negotiate_protocol(&ghcb_protocol_info)) return false; /* @@ -794,6 +797,14 @@ void __init sev_es_init_vc_handling(void) /* Secondary CPUs use the runtime #VC handler */ initial_vc_handler = (unsigned long)kernel_exc_vmm_communication; + + /* + * Print information about supported and negotiated GHCB protocol + * versions. + */ + pr_info("Hypervisor GHCB protocol version support: min=%u max=%u\n", + ghcb_protocol_info.hv_proto_min, ghcb_protocol_info.hv_proto_max); + pr_info("Using GHCB protocol version %u\n", ghcb_protocol_info.vm_proto); } static void __init vc_early_forward_exception(struct es_em_ctxt *ctxt) -- 2.31.1