Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp4283pxv; Wed, 21 Jul 2021 13:56:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSJukQxd7vAVYOS2TGF7zjozgs7upFb0geDviw9P8iWvhcekti17VjX13LizV3sFpNsDmH X-Received: by 2002:a05:6402:1347:: with SMTP id y7mr50825902edw.87.1626900996737; Wed, 21 Jul 2021 13:56:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626900996; cv=none; d=google.com; s=arc-20160816; b=dNGyx/MciADBCGcoid8oZ6X9KPcDSP4K/GS9JgwFyj/KZloTCOSgn0yDqoDoDtlnP7 IPeAATB/frEuVkNctaqwsI2E7fOgvbHqSDtxu71Qc+u9GkjjLdU0TDC3bphLhVNBxzG4 c1C+uc3KXlHO3nJxMWIvLHwu681u+jFzYv2AHqHpc9Tngxt9NCRes5XnxdMoKCPuFwac 3FkLBJLhzJ2lSr1GFibMRvlzVy+olist4A2Euq7+HPYcnbP3zbF9fXQht71KKu0uJRUc G40UMdsZFfWODUD06llk3KFQXrTEeetvwXX0dQ+hIN5jMNAY2O5Bcb4TAuWFHSdtq8w6 cGMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=oHRy9AsgzPEVoR5nChd5ww7JZZ3Qwj9GnYmiswZFwpE=; b=pG9QQNxGcWmtNQGcvhldqHUOrm0SgRJEQAZKyOKKqL+ndb0g69AUrnesE6EHKsd3iH F3U7oP2bZ2LEme5xJ3lMD17fo/8ozcvsBPGRxDIzA32hOdVhwLI7tLQDMI+eLjwG3xWx vyUUh+0TfH70CoH46s4IOR+EhQ4LQgoxKwdljSlAbzvQklesUa0EiiGw0FCRd4tjwFo/ x+WL5O2P6FAvnFakVeH6P10qcQX/Wz86U9Gpz63tyeDERAAjf9lVAxpU6PPunT32cee9 p5OrkK3aQJOjCengkJYOwraNblfrDYTaJHi+Tzxh79NAwBg8zX3Chy63w3X2QdmUHXtf 1WGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=tuC7TNZ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce9si25220172ejc.253.2021.07.21.13.55.49; Wed, 21 Jul 2021 13:56:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=tuC7TNZ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229777AbhGUUKX (ORCPT + 99 others); Wed, 21 Jul 2021 16:10:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:59058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbhGUUKW (ORCPT ); Wed, 21 Jul 2021 16:10:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2F76460FEA; Wed, 21 Jul 2021 20:50:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1626900658; bh=iPgc6ODsz4TxG0bpAFE63PzUmM0U3DXOBMd9a7IulMc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tuC7TNZ5RmKRaB07c88XWWZDEI4hetYXiE0Qb7/LwJPcIZEQjmJpI1w/Y8kgHJjNi 5wYMrf3nlLL4i22bJZXRHDfgvSGWmqflPgI7CFVY+fkPKsGB+P8IMp3/oSU1Qt2pP1 SqaL65gU1IP7oBK0HyD9zjPysNWnP/OqPWo9pZ+A= Date: Wed, 21 Jul 2021 13:50:56 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: David Hildenbrand , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , Jann Horn , Shakeel Butt , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , linux-mm , LKML , kernel-team Subject: Re: [PATCH v2 1/3] mm, oom: move task_will_free_mem up in the file to be used in process_mrelease Message-Id: <20210721135056.84d12dd49c07adff7b0beffb@linux-foundation.org> In-Reply-To: References: <20210718214134.2619099-1-surenb@google.com> <7eb17da6-03a6-5eaf-16e6-97b53ba163d8@redhat.com> <20210720160707.2332738708948f7d865d67c1@linux-foundation.org> <0ee6775b-589c-3243-1c01-aafad5eecb73@redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Jul 2021 13:19:35 -0700 Suren Baghdasaryan wrote: > > > This would not require moving other functions. > > > Would that be better than the current approach or the forward declaration? > > > > IMHO that could be an easy, possible alternative. > > Andrew, others? Should I follow this path instead? Whatever you prefer ;)