Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp11038pxv; Wed, 21 Jul 2021 14:04:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw01lifPWfCHjh/7Asc/JSWC9hm5ImkR0FUM4KpcAP+fy9VodUmMNuiDydJVnbXU2VjoOrF X-Received: by 2002:a05:6e02:f53:: with SMTP id y19mr26876197ilj.181.1626901444057; Wed, 21 Jul 2021 14:04:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626901444; cv=none; d=google.com; s=arc-20160816; b=BesJn2tQWqXswdwpnDInQVx8xpqOTJM1lfrTnuxnSZB7JnlMZDlOsIrEbcKOffwtYi +r9Gh/zMnUXY0eGBOsgq0XmT4pjBAk9fR0BHEHYuJrbuh/6BQDkH3WSQqn70ltIEev5P 4GXQA8mzDACAyHUHtMdeM9gKIl6+uqX402YF1cmjWU0ZIBOlWrt2y1MJVutQaH2rRj6U vtFF/bE4gmjsLic7T9UTMqewILWZMwKa6j44tjQGROrrBROvMhLJBOyShrMzNBmxUFdD e7TSH21zk5qhwvP+bIJq48DNSD0rBxklxSRFJkfknWQ1tZtUBwK1N+yR2jUzDpCjidij eOIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=V68QkkCRxVc1i8IofVKRhJiTH9nwdrtSj5K+hf6SL3A=; b=EJAaPibgbWVIJwxWM2Fhq6QpkdwBvK5lI0Bdn+u3MlDZg6reKI0C4r/u18+/t067ku aQsu33z4Jq59cWLP32k57P+y7HgM/U8CTmIyL/oyOHkW3mUTw01WOyp8TAvZfp8RA3OB Nqk7frwRujpRIKvO56+1Fn+c9aPsWqpAP744jUP98rUnduiu1lZFWC+xU03z46pLwBY1 bLs3lcibX3/mep7ltX6lSVTlHtsjbLQ5qWXxBERF7RqaVWPtIqIPzYCWff2fatEuwOS0 h4y1ASMZmK2gBx9BWlagm+xTWHeDu5sto2B3L/5ftboqvvVix8/9s2OtsAdTzDvOldjZ H6TA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=QmDN9hS4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y18si7250168ily.67.2021.07.21.14.03.52; Wed, 21 Jul 2021 14:04:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=QmDN9hS4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbhGUPis (ORCPT + 99 others); Wed, 21 Jul 2021 11:38:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbhGUPir (ORCPT ); Wed, 21 Jul 2021 11:38:47 -0400 Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DB70C061757 for ; Wed, 21 Jul 2021 09:19:24 -0700 (PDT) Received: by mail-oo1-xc32.google.com with SMTP id a17-20020a4ad5d10000b0290263c143bcb2so676368oot.7 for ; Wed, 21 Jul 2021 09:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=V68QkkCRxVc1i8IofVKRhJiTH9nwdrtSj5K+hf6SL3A=; b=QmDN9hS4Aq/Di8SdCrH1vSQoFJ/Q/xVzyRhfkzJ22KWmfjcK0eH7T3dVqpvIG5LNMj 6z6bK8tU33NlW6ci8Z53KcDlDdQVCly4q0vvcMPysc+SDXFkl9kJzd0uPnEJcuDt8etH xOJJRx5ljPtZ6z1WK7Z/wtV/ZTttvNoDU6ZTeVCVaa6KtRehPQi6mx8sWraywkqUwYHL PaWpU8RB9/rtkKEcq9c0+G+K+DHpoCoQK+HwG9Brxok5ZJWQEpABRdopI4zB3aF4miye JtfA69zuK+3fIlYfkTwiacsDcw4lXdeLOR8uPA/lSDPuGQ1VubBUIqn62kx+5pSJBnYI H8Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V68QkkCRxVc1i8IofVKRhJiTH9nwdrtSj5K+hf6SL3A=; b=MjS4+kGD/MO2JzLO3xfHpLO08c/CWKjeOyPp+79LTJnWCKvEzS1eMZn2OO9oNSEYiT 0bn/vxOvyH+EXtsyj2Jjx/zSpm8nJSSyCVzpwHsgG4gXbxfQyoxnvrTYoQPb6LqVSPkc Gj7Fg51qE9isNWZj4suU28rBckvOJvJVz1kF065a44/breTUjDNAz/OU2yfCkesgEwZA J2g36GlwH4AY+QpuhtjmaERZZEmv8xk6+4SP83m2h7eobrbAvMRP72bWBWNPVrstMtbZ HPfVpnR2mE0XxYwGuDRhNOT3nEU+TVAUy8W+FSzvDwX4kIVjQPj01WP+JAbyWynjUR3O UVJA== X-Gm-Message-State: AOAM530AXSOczf6CHwgxQhweZPL1XQa3tKZj1Q9po984tujyv6dP9XMu o+YQ9FcUOx3y7Bhd5KOxjkNYnt4tigUeNQ== X-Received: by 2002:a4a:c3c1:: with SMTP id e1mr22457265ooq.93.1626884363447; Wed, 21 Jul 2021 09:19:23 -0700 (PDT) Received: from [192.168.1.170] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id p4sm4478415ooa.35.2021.07.21.09.19.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jul 2021 09:19:23 -0700 (PDT) Subject: Re: [PATCH] block/bfq: the delta_from_first should be ns rather than us To: Paolo Valente , liubaozhu Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210721063047.92122-1-liubaozhu@uniontech.com> <3A3B282C-FA5D-43F3-9C78-5E257C93A835@linaro.org> From: Jens Axboe Message-ID: Date: Wed, 21 Jul 2021 10:19:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3A3B282C-FA5D-43F3-9C78-5E257C93A835@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/21/21 1:54 AM, Paolo Valente wrote: > > >> Il giorno 21 lug 2021, alle ore 08:30, liubaozhu > ha scritto: >> >> In the block/bfq-iosched.c,the function bfq_update_peak_rate(), >> bfqd->delta_from_first = now_ns - bfqd->first_dispatch, >> according to the subtraction operation here,now_ns is ns, >> and bfqd->first_dispatch is also ns,so bfqd->delta_from_first should be ns. >> > > Correct! > > Acked-by: Paolo Valente > Just pick this up for your 5.15 series and include it in that. -- Jens Axboe