Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp11088pxv; Wed, 21 Jul 2021 14:04:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrWPmsT+/s9DUdirNw4WkBEH4ZnlsuIboaZ5xO4Yj0279c69Ag5X0xHmPf2Ef2zsK2VeAx X-Received: by 2002:a92:8e41:: with SMTP id k1mr14652023ilh.276.1626901446880; Wed, 21 Jul 2021 14:04:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626901446; cv=none; d=google.com; s=arc-20160816; b=r/Y3FzNNP4fZ3N0pTF2/sOQ7qa/1tl+nJm7txYBsC+8YtAehk2ApIaopKGiXLN6KSG NQQadqplCOnKQ3SS0ZAe0YNsoglTn33VKj+aNHA103VBqhdC0Qy1AIaT/T7DEVyEVrGl qXoZLyHIus7ivHTzd7oXmIjoSICyE7GOpyebR6NJyTDl7wkHuDtvs0E0eTwqaXrTb8Bj VNmkUkxz02RTb9intS3BvKLDyNMznHif/HXESmtTHYExGERRivJyVI0CD7cnYc6JmDNe lybGOIAWyznu6GyA65r/0PC9bZHQPRT7i+qSoiMcHJv5ruIie9TmZsQYfwmtQ+KEoCuy g2tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=Kjj8+BH+iUI89w/Sp2sMFJ5Avc7T3JxTFrtEGyjxaBQ=; b=ZhS1kb/sC40gR7KJQJ1qc3j2cJZiEMV3N+HUlNyOhaX3nQReYMBIAaU3cf5TdTKiQv ttTFG/Z6HB0BprGqPl4ukDHNz0WLPvYwr8Jp6IjPyuD+B6GCLP6HcImZFBNFpnAG6G6P mZHuWU8Lll/o6Zd0okswvX1eCxV5qie001YnQAvE0RnbxMS84x0iPT+xG/hAA03kCeoE 30cuARY1mfvgQI//uWBIRR26lxw93FOCT34VHjrgefB5PxiyIbN+sVc1sW0vW79s+f/c THnJI04JPFy9mHSJYPjox8JX6bXXeWCKe/JKIgrMlxhttZj7xvUtlwhBLladdrjbtZjO whFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XXNG8+7H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x3si28700378ion.71.2021.07.21.14.03.55; Wed, 21 Jul 2021 14:04:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XXNG8+7H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234399AbhGUPoe (ORCPT + 99 others); Wed, 21 Jul 2021 11:44:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234504AbhGUPnM (ORCPT ); Wed, 21 Jul 2021 11:43:12 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B399C0613D3 for ; Wed, 21 Jul 2021 09:23:39 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id p9so1964813pjl.3 for ; Wed, 21 Jul 2021 09:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Kjj8+BH+iUI89w/Sp2sMFJ5Avc7T3JxTFrtEGyjxaBQ=; b=XXNG8+7HGwsUlnbqf8ot4dPVWPtCkTgNVpc6SdD8Z6243I+AAwPeuM/4e8DFu0Ymuh 7mM0JIoTEzMZhOhgrbRTqQU4InFQJZ6OD5YkXSAp91wa0pJdL/7UQ74UN0xSRhu5PlKP DF5haisPbTop21XhxVvV05N7efTm6TIFPaQ3GeVLRnqV+BDqo6OEXL+lLjeoVZKJib4o ciF7VJtDesOdE9vODJeu/2I6V282VsCoyiAQsIRVYD98zt6SAm1SCOcFklwxWfs5Tiwz G1T1o4AAqw//GrUi7t/Xost+6+6jmjVspJ+N8HkoEuqiQjA3ANqylYu7CK2Ymm7SyCnM b+7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=Kjj8+BH+iUI89w/Sp2sMFJ5Avc7T3JxTFrtEGyjxaBQ=; b=cvmfKQXsiAt7h5ep1gBR3sty6lIVXfYCc4K+k9eFwX4WFo+Tvlqi5WvHhZ02rTLoxu kAC7tSx4Mlda/cjLZToBXe3V0NpVENGezRXYmMLe2nX5IkCm4QvFndnAOhmk/BBx/p7s aBFYqevfZouEZMnz/9ELH0zFJz4rM2Cw4xqdXVrWhTpON+rSisxSZic4Qp/fiTpgz22L +JkA6btMoeKV65ssW3GYqRadgyR9WOjQ8xxdG6QpkLdcWFDsgif/17VpYA8vw1zaD9K4 IjAcEwKJMDeC+VvIGHMj90MvoB+w8HewbVDMTQREOjnWgCe7AFdgsyNcRoGAuQSnmTF3 ICgg== X-Gm-Message-State: AOAM531sTsgEjeTJuuyzajP6KfcDsNP4uiCwxcNTsii7UgaWxo4Am96l 9qVp8lfbMVRKDKAAhoWap2U= X-Received: by 2002:a17:90a:fe93:: with SMTP id co19mr33913094pjb.206.1626884618413; Wed, 21 Jul 2021 09:23:38 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:e9f1]) by smtp.gmail.com with ESMTPSA id v69sm28426072pfc.118.2021.07.21.09.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jul 2021 09:23:37 -0700 (PDT) Sender: Tejun Heo Date: Wed, 21 Jul 2021 06:23:33 -1000 From: Tejun Heo To: Lai Jiangshan Cc: Zhen Lei , linux-kernel Subject: Re: [PATCH] workqueue: Fix possible memory leaks in wq_numa_init() Message-ID: References: <20210719065914.3801-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 19, 2021 at 04:49:05PM +0800, Lai Jiangshan wrote: > Hello, Tejun > > I think it would be better to fix it. > There have been several tries, sorted by date: > > https://lore.kernel.org/lkml/1418379595-6281-2-git-send-email-laijs@cn.fujitsu.com/ > https://lore.kernel.org/lkml/1442457835-24238-1-git-send-email-xlpang@126.com/ > https://lore.kernel.org/lkml/1452170339-26748-3-git-send-email-wanghaibin.wang@huawei.com/ > https://lore.kernel.org/lkml/1533518439-3982-1-git-send-email-wang.yi59@zte.com.cn/ > > And this one. Yeah, idk. It's not an actual bug tho. Maybe we should just add a comment. Which version do you like the best? Thanks. -- tejun