Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp11640pxv; Wed, 21 Jul 2021 14:04:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+ITjy6b9itFFy5xP3iuLu4sdm79IIchFyUZWaF/9VPCudFzVWI7Ij/3ZkFyyO7F3hhLLt X-Received: by 2002:a05:6638:3887:: with SMTP id b7mr30944190jav.42.1626901365070; Wed, 21 Jul 2021 14:02:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626901365; cv=none; d=google.com; s=arc-20160816; b=p03ZtZmYQONbxOkyan6E11ndrWWsERKUP3TmUly3DmFKnbTduQAxFNhULE9+r6hdJ5 bL0Au6rwSNc8tEgqYGo7q31HptncUjXqtA+OvWJhvrmsVm0NF8AjEqPHmpF1KcnOC88/ v3saXpeSstMBaqb6M3s/WvDRdGkuPiYM/SHCTIJXUTEPylg7JChkekTE55KlHJmv4Vu7 VmDN0eBHbBLDGFUBgV1Jn/NBC/hXeQYEn+jE7iVfGBCjmqmv2GKkGL8LHsnH64U0jVAW sgPnClXrw9tRCiSapcqoAEmywyQgjEMICT6a3Ft33GcwPnEQXZT3QIGv2EEkYX5zOL4j 3yUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=9paZxVKmlnrGyH3BZS1g02F/MKDX+Zs2JXAWYxmUbMU=; b=Nj5PwqXOo56vmrh+CVx3vr18NtMS3uDEEUGPuX6MUJ4iQ7skCP/w9TZiFqNfIjaUCQ XSO6qDxdJ8kVaY4ntFKka+681VGefrDVG7rKW8RckG/ySxZCuorHIJz8imZkwZ/3/Mn2 q6lGkk9O7KeeUgkOrwbrpLian2cYQu8c6Qa8Y7v5YhtX+Dw/j2rWljMMsO98R0ElLafC N5QSS/knOXWS9m56Z8YVmBTq9SlQkfyrsUL5nIMvWp4aT/2SsJI8MgTPfTqdSi60sTGj h0UvJiZxHyx8Wa+wMFFQN9+5kGxV+IAY+7Ri2NMyLKEB+Fc8gcKj1KYEvjA1n4O+UCN5 nDRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=rXcyRF6D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si28947135jat.42.2021.07.21.14.02.33; Wed, 21 Jul 2021 14:02:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=rXcyRF6D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239952AbhGUOz0 (ORCPT + 99 others); Wed, 21 Jul 2021 10:55:26 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:35790 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233009AbhGUOzZ (ORCPT ); Wed, 21 Jul 2021 10:55:25 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3CE3122460; Wed, 21 Jul 2021 15:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1626881761; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9paZxVKmlnrGyH3BZS1g02F/MKDX+Zs2JXAWYxmUbMU=; b=rXcyRF6DaEwOudL2odmgq6YLcIwkaT7kNn48uek7LcgGM40qqvy4/DyDG0C6cACBn3uOTV PhEKdWKJccazhmoKff9FhFcBIms1TWmQmeUwT/xEkMXN+lRyqoF8A6tqtmDoHqt/wGjsag uDWGjgHf1BmKEWQXimc8jaNcV+otcVs= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 11D2B13C02; Wed, 21 Jul 2021 15:36:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id gE4gA+E++GDiNgAAGKfGzw (envelope-from ); Wed, 21 Jul 2021 15:36:01 +0000 Subject: Re: [PATCH] xen/events: remove redundant initialization of variable irq To: Colin King , Boris Ostrovsky , Stefano Stabellini , xen-devel@lists.xenproject.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210721114010.108648-1-colin.king@canonical.com> From: Juergen Gross Message-ID: Date: Wed, 21 Jul 2021 17:36:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210721114010.108648-1-colin.king@canonical.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TwP4P4bBnCJdQ1LiYRgMlQM3ILh6GJVzz" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TwP4P4bBnCJdQ1LiYRgMlQM3ILh6GJVzz Content-Type: multipart/mixed; boundary="crVZNEQBD7obEX4izqKXbU7wshd2Q55mK"; protected-headers="v1" From: Juergen Gross To: Colin King , Boris Ostrovsky , Stefano Stabellini , xen-devel@lists.xenproject.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH] xen/events: remove redundant initialization of variable irq References: <20210721114010.108648-1-colin.king@canonical.com> In-Reply-To: <20210721114010.108648-1-colin.king@canonical.com> --crVZNEQBD7obEX4izqKXbU7wshd2Q55mK Content-Type: multipart/mixed; boundary="------------11DEC1EB2920679203CA73DD" Content-Language: en-US This is a multi-part message in MIME format. --------------11DEC1EB2920679203CA73DD Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 21.07.21 13:40, Colin King wrote: > From: Colin Ian King >=20 > The variable irq is being initialized with a value that is never > read, it is being updated later on. The assignment is redundant and > can be removed. >=20 > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Reviewed-by: Juergen Gross Juergen --------------11DEC1EB2920679203CA73DD Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------11DEC1EB2920679203CA73DD-- --crVZNEQBD7obEX4izqKXbU7wshd2Q55mK-- --TwP4P4bBnCJdQ1LiYRgMlQM3ILh6GJVzz Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmD4PuAFAwAAAAAACgkQsN6d1ii/Ey9k 1Qf/bQxoK25f57csMLkItMOO46yMlUwEHEj2mjgvlwnFCd/E3kQQVDUtUF4yjwu+2Vp58lK7SzIE g5bCPoQWGE64PlwQnKvHZ8N5phekEPGPfLItjXB9i838Xs3F1yBP+tBLToka/6yM3m60l1D4eBxU X90dhYuhfCAWafaDAyIlGK1+pHMmNUJavUt29HJC3SECP4qB9TA5Kj6ZzpYI3X1ve+4ge+lu1PWM 7TBClWSKcLybGDx9sra+Il1aXBpQ/Zt/mXFj/RQ39lWDrtV5DHOZopYQQpenUf/ceXD25W7GEHMH xigdD8NckUa7+KridAV4jH/rpMflqlWJk/0fU87U8Q== =w9/s -----END PGP SIGNATURE----- --TwP4P4bBnCJdQ1LiYRgMlQM3ILh6GJVzz--