Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: sibis=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 21 Jul 2021 23:11:35 +0530
From:   Sibi Sankar <sibis@codeaurora.org>
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     bjorn.andersson@linaro.org, mka@chromium.org, robh+dt@kernel.org,
        saiprakash.ranjan@codeaurora.org, will@kernel.org, ohad@wizery.com,
        agross@kernel.org, mathieu.poirier@linaro.org,
        robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de,
        linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, evgreen@chromium.org,
        dianders@chromium.org
Subject: Re: [PATCH v2 08/10] arm64: dts: qcom: sc7280: Add nodes to boot
 modem
In-Reply-To: <CAE-0n50HwmuYWnqs9TYJYEoB=-BV8Bbz+AMUUy5t9dtN1jSsjA@mail.gmail.com>
References: <1626775980-28637-1-git-send-email-sibis@codeaurora.org>
 <1626775980-28637-9-git-send-email-sibis@codeaurora.org>
 <CAE-0n50HwmuYWnqs9TYJYEoB=-BV8Bbz+AMUUy5t9dtN1jSsjA@mail.gmail.com>
Message-ID: <11b5493ecb6118ec8c5fd49ec7a85aa3@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-07-21 11:14, Stephen Boyd wrote:
> Quoting Sibi Sankar (2021-07-20 03:12:58)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi 
>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 5ed7a511bfc9..3fb6a6ef39f8 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -1219,6 +1224,21 @@
>>                         };
>>                 };
>> 
>> +               imem@146aa000 {
> 
> is sram a more appropriate node name here? Is imem a generic node name
> in DT spec?

binding check for qcom,pil-info.yaml
didn't complain so I just followed
it. AFAICS, sram isn't mentioned in
generic node names either.

> 
>> +                       compatible = "syscon", "simple-mfd";
>> +                       reg = <0 0x146aa000 0 0x2000>;
>> +
>> +                       #address-cells = <2>;
>> +                       #size-cells = <2>;
>> +
>> +                       ranges = <0 0x0 0 0x146aa000 0 0x2000>;
>> +
>> +                       pil-reloc@94c {
>> +                               compatible = "qcom,pil-reloc-info";
>> +                               reg = <0 0x94c 0 0xc8>;
>> +                       };
>> +               };
>> +

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.