Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp87832pxv; Wed, 21 Jul 2021 16:30:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvQZ4CzIs5Vb9xfndocJU/VyOKigehIKNg3YVHM6LAXfrZ0EhAW0nyrCZgUc+41mEWKEOg X-Received: by 2002:a05:6402:18de:: with SMTP id x30mr51673605edy.351.1626910252998; Wed, 21 Jul 2021 16:30:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626910252; cv=none; d=google.com; s=arc-20160816; b=SsGfw3jnSMLjKX1XYUT232YyXAfmF9eDQ2arK+nElIZhrx2yw/pztyV1jaD6455MJK Ul2e1HHQa3PKTx/NPNqxOOIvtULMVCFY/+7R5FOJgWqxpjsEKqq9cG4T8L9JXMkk1TNu KrEfNo/Pjhqoo1epFqkTk7aHb+RVCDu6T2c1iU5oweUNh/vJHBt1almyWS4Vfs0ROpZm UBd+PM0oZaefngv/+YpzuAqJEHGwDzBKd+MxHYgLq7tbmwnbyU6gsWy1gbrGhc5HeII2 CBwGnUb776nAy4pBDF+rS6cyXOdCIp2e2boUw+5u1C9WXB2ChYXm3CqBtskPjTIhW/wF erjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=GoKHY31AUl/WmIbrWvstEpC6nwWnu/aYYQ5eVh88pmQ=; b=pCn8qHpI+M90rm6EMV0ZnZDEpuooQd5bmWm+yT8R78RGlikZlvjkAtTS0OkwjAHI1E SxtociI/lH56cB4R5vwLDHa4vF2Hzq0IEmiM6w7sZemVEJAcVz9t/+XDWsxqGo1JMqVq alL8+HBxPRTSlBg2haHBYb37/Tl+ftxIcn4enzmDj3AKtPFHMsH4LM6LhQPqlLeuEZ/f rBLP5Nmzz9MLYPP4rtmNapgteJfx4DsUmd9adbAaWJP9cFejDvkLEhqmrCzpdwJrwa4j stjKpLd/WcijFjvVpWbkDIPacqVLz1KiwW8Kny2LXO+avdVjKdoUj78xoWeHabbeWg2B SFRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ozlabs.org header.s=201707 header.b=FA5Ym+Gs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ozlabs.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z62si19142257ede.60.2021.07.21.16.30.30; Wed, 21 Jul 2021 16:30:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ozlabs.org header.s=201707 header.b=FA5Ym+Gs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ozlabs.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231213AbhGUWsC (ORCPT + 99 others); Wed, 21 Jul 2021 18:48:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231204AbhGUWsC (ORCPT ); Wed, 21 Jul 2021 18:48:02 -0400 Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FB01C061575; Wed, 21 Jul 2021 16:28:38 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4GVWwx0lfNz9sV8; Thu, 22 Jul 2021 09:28:32 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1626910114; bh=GoKHY31AUl/WmIbrWvstEpC6nwWnu/aYYQ5eVh88pmQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=FA5Ym+Gs70MifbuFfkuM8sCA6mPXNMq4AZgTsP743W2eJikolBaegABYpt7ziNCX0 YpbZ741z/evpIlqL0SNxLPw0AS5PEC0fMzizB5sG4pk7CscPu4KzNFlHg1OHNrKZwo wkOPAxugW5aO8km38+a3cmYqrWg5x5Da6PW4D9IHTXK0qi46nu/zj+Eg6OtIo7yQeR hOB+s8+o5p9RGW7ebPM2LQ/Qt305lDSU6dZ4v5aV6gUSCyVklP9F+G9wHbnK+pD+x8 oDIXfKB6LbMNExnTOnUJCeyIPs0tXjbw4k8UR1Jj7/LBdpIh+7w23MeXjc573Os2zg VNwEbve7Xomag== Message-ID: Subject: Re: [PATCH 3/3] fsi: occ: Add dynamic debug to dump command and response From: Jeremy Kerr To: Eddie James , linux-kernel@vger.kernel.org Cc: linux-hwmon@vger.kernel.org, linux-fsi@lists.ozlabs.org, linux@roeck-us.net, jdelvare@suse.com, joel@jms.id.au, alistair@popple.id.au, openbmc@lists.ozlabs.org Date: Thu, 22 Jul 2021 07:28:27 +0800 In-Reply-To: <20210716151850.28973-4-eajames@linux.ibm.com> References: <20210716151850.28973-1-eajames@linux.ibm.com> <20210716151850.28973-4-eajames@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Eddie, > Use the dynamic branching capability of the dynamic debug subsystem > to dump the command and response with the correct OCC device name. Would this be better done with a tracepoint? Given it's a fairly well-defined pair of events, and there's data to dump in both cases. We have a couple of existing tracepoionts in the core code if that helps... Cheers, Jeremy