Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210714091327.677458-1-mudongliangabcd@gmail.com>
 <YPfOZp7YoagbE+Mh@kroah.com> <CAD-N9QVi=TvS6sM+jcOf=Y5esECtRgTMgdFW+dqB-R_BuNv6AQ@mail.gmail.com>
 <YPgwkEHzmxSPSLVA@hovoldconsulting.com> <YPhOcwiEUW+cchJ1@hovoldconsulting.com>
In-Reply-To: <YPhOcwiEUW+cchJ1@hovoldconsulting.com>
From:   Dongliang Mu <mudongliangabcd@gmail.com>
Date:   Thu, 22 Jul 2021 13:32:48 +0800
Message-ID: <CAD-N9QVD6BcWVRbsXJ8AV0nMmCetpE6ke0wWxogXpwihnjTvRA@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] usb: hso: fix error handling code of hso_create_net_device
To:     Johan Hovold <johan@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Oliver Neukum <oneukum@suse.com>,
        Anirudh Rayabharam <mail@anirudhrb.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Rustam Kovhaev <rkovhaev@gmail.com>,
        Zheng Yongjun <zhengyongjun3@huawei.com>,
        Emil Renner Berthing <kernel@esmil.dk>,
        syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com,
        YueHaibing <yuehaibing@huawei.com>, linux-usb@vger.kernel.org,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jul 22, 2021 at 12:42 AM Johan Hovold <johan@kernel.org> wrote:
>
> On Wed, Jul 21, 2021 at 04:34:56PM +0200, Johan Hovold wrote:
> > On Wed, Jul 21, 2021 at 04:17:01PM +0800, Dongliang Mu wrote:
> > > On Wed, Jul 21, 2021 at 3:36 PM Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > On Wed, Jul 14, 2021 at 05:13:22PM +0800, Dongliang Mu wrote:
> > > > > The current error handling code of hso_create_net_device is
> > > > > hso_free_net_device, no matter which errors lead to. For example,
> > > > > WARNING in hso_free_net_device [1].
> > > > >
> > > > > Fix this by refactoring the error handling code of
> > > > > hso_create_net_device by handling different errors by different code.
> > > > >
> > > > > [1] https://syzkaller.appspot.com/bug?id=66eff8d49af1b28370ad342787413e35bbe76efe
> > > > >
> > > > > Reported-by: syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com
> > > > > Fixes: 5fcfb6d0bfcd ("hso: fix bailout in error case of probe")
> > > > > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> > > > > ---
> > > > > v1->v2: change labels according to the comment of Dan Carpenter
> > > > > v2->v3: change the style of error handling labels
> > > > >  drivers/net/usb/hso.c | 33 +++++++++++++++++++++++----------
> > > > >  1 file changed, 23 insertions(+), 10 deletions(-)
> > > >
> > > > Please resend the whole series, not just one patch of the series.
> > > > Otherwise it makes it impossible to determine what patch from what
> > > > series should be applied in what order.
> > > >
> > >
> > > Done. Please review the resend v3 patches.
> > >
> > > > All of these are now dropped from my queue, please fix up and resend.
> >
> > A version of this patch has already been applied to net-next.
>
> That was apparently net (not net-next).
>
> > No idea which version that was or why the second patch hasn't been
> > applied yet.

It seems because I only sent the 1/2 patch in the v3. Also due to
this, gregkh asked me to resend the whole patchset again.

> >
> > Dongliang, if you're resending something here it should first be rebased
> > on linux-next (net-next).
>
> And the resend of v3 of both patches has now also been applied to
> net-next.
>
> Hopefully there are no conflicts between v2 and v3 but we'll see soon.

You mean you apply a v2 patch into one tree? This thread already
contains the v3 patch, and there is no v2 patch in the mailing list
due to one incomplete email subject.

BTW, v2->v3 only some label change due to naming style.

>
> Johan