Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 22 Jul 2021 10:21:37 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Jernej Skrabec <jernej.skrabec@gmail.com>
Cc:     wens@csie.org, robh+dt@kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: allwinner: h6: tanix-tx6: Add PIO power
 supplies
Message-ID: <20210722082137.2kgbirwtayq4bl7x@gilmour>
References: <20210721200832.916644-1-jernej.skrabec@gmail.com>
 <20210721200832.916644-2-jernej.skrabec@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20210721200832.916644-2-jernej.skrabec@gmail.com>
Precedence: bulk

Hi,

On Wed, Jul 21, 2021 at 10:08:31PM +0200, Jernej Skrabec wrote:
> While there is no publicly available schematic of this board, it's not
> hard to determine voltage of GPIO port C, D and G (only ones which can
> be set).
>=20
> Port C and G are used for MMC/SDIO communication, so they use 1.8 V
> power supply. It's not clear if port D is even used, but if it is, it's
> pretty safe to assume it uses 3.3 V power supply. Value read from PIO
> Group Withstand Voltage Mode Select register from within pre-installed
> Android agrees with that assesment.
>=20
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
>  .../boot/dts/allwinner/sun50i-h6-tanix-tx6.dts      | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts b/arch=
/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> index be81330db14f..a1dd8f472cc8 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> @@ -32,6 +32,13 @@ hdmi_con_in: endpoint {
>  		};
>  	};
> =20
> +	reg_vcc1v8: vcc1v8 {
> +		compatible =3D "regulator-fixed";
> +		regulator-name =3D "vcc1v8";
> +		regulator-min-microvolt =3D <1800000>;
> +		regulator-max-microvolt =3D <1800000>;
> +	};
> +

I appreciate that the other 3.3V regulator has the same issue, but the
node name must reflect the class of the device. Maybe regulator-vcc1v8?

Maxime