Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp376966pxv; Thu, 22 Jul 2021 02:20:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwASFIYf7PY3v/CPsQRcpMXp6B8iFB8RMe7NnGSdS+PSipUsejh9XI2BOX5dCqsVz2daGe X-Received: by 2002:a05:6402:168f:: with SMTP id a15mr53566989edv.3.1626945607448; Thu, 22 Jul 2021 02:20:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626945607; cv=none; d=google.com; s=arc-20160816; b=mukPnj1jt5UEQRLu4zILtQTxjyV2AQhXzBkxDn7eZtl2bvV56gy/z8uHAi0dRufdAT fs9/9YCMbOF0urvVjdVEtAsJlxN/JFky5WeExuGq57YCyFpgU0SbbdYYvebs7aunGnsJ tD5kSaaBBOW8Vz/o0elvrG4UKgPnIJnb4o/TnSd+Yx9NrG/Qva171+fe93CIlx+lf0bn oNmp2gBuNe/4B2ddhVjTqoINUg0HQpjJPRjFMC1qs+3WoSPmTj9GoNXPCNJJKJno8D6o UxtIdJ6Qhp6830OJylS9x+4cEX4UaGgIah8uOHACW8Gb9Hg8KI3MaJrNQiYbIGWYTumn 0ntg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=aXlG0bFKShKekqbrpoZoCxPEc3+bmBqe0MI/N1YH/9k=; b=dkNdaUNngn8AjjVQ90Fipgx8DVGT0ioXZ/NQ5N2ZDU4JfgP1Wi5dXlCqp+OxZfFSjn Iw61wOPrBxSLrVLpHOVbLfOD4A0qEQ4SGbn2srBKW3F6p50FDdmYzIoSO9CWToHnAliP LJmLpB7nbYRT7p2Mvk6e9ZalJuVrvd19yFUpPB/aqckKL9Ff89k1Ei8DzvmMR9/wBrR/ BTzMjxkn6XaOSXPRSDmjbrdFr4/YpBZqKAsowysfZsQv12pxnWmpgBboGdLqV1wotsQH 9bSxnRB0nqCTUHXrrxYXDcfhaT7uqzYOv2nd47KrIeb8BvoScp2bjdRhttFpB9K6YinV HZhA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lj1si30527832ejb.330.2021.07.22.02.19.43; Thu, 22 Jul 2021 02:20:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231282AbhGVIhx (ORCPT + 99 others); Thu, 22 Jul 2021 04:37:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230419AbhGVIhu (ORCPT ); Thu, 22 Jul 2021 04:37:50 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9515BC061575 for ; Thu, 22 Jul 2021 02:18:25 -0700 (PDT) Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6UqE-0001NK-VX; Thu, 22 Jul 2021 11:18:06 +0200 Received: from afa by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1m6UqC-0001Ch-DB; Thu, 22 Jul 2021 11:18:04 +0200 From: Ahmad Fatoum To: David Howells , Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Song Liu , Richard Weinberger Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, linux-security-module@vger.kernel.org Subject: [RFC PATCH v1 0/4] keys: introduce key_extract_material helper Date: Thu, 22 Jul 2021 11:17:58 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: afa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While keys of differing type have a common struct key definition, there is no common scheme to the payload and key material extraction differs. For kernel functionality that supports different key types, this means duplicated code for key material extraction and because key type is discriminated by a pointer to a global, users need to replicate reachability checks as well, so builtin code doesn't depend on a key type symbol offered by a module. Make this easier by adding a common helper with initial support for user, logon, encrypted and trusted keys. This series contains two example of its use: dm-crypt uses it to reduce boilerplate and ubifs authentication uses it to gain support for trusted and encrypted keys alongside the already supported logon keys. Looking forward to your feedback, Ahmad --- To: David Howells To: Jarkko Sakkinen To: James Morris To: "Serge E. Hallyn" To: Alasdair Kergon To: Mike Snitzer To: dm-devel@redhat.com To: Song Liu To: Richard Weinberger Cc: linux-kernel@vger.kernel.org Cc: linux-raid@vger.kernel.org Cc: linux-integrity@vger.kernel.org Cc: keyrings@vger.kernel.org Cc: linux-mtd@lists.infradead.org Cc: linux-security-module@vger.kernel.org Ahmad Fatoum (4): keys: introduce key_extract_material helper dm: crypt: use new key_extract_material helper ubifs: auth: remove never hit key type error check ubifs: auth: consult encrypted and trusted keys if no logon key was found Documentation/filesystems/ubifs.rst | 2 +- drivers/md/dm-crypt.c | 65 ++++-------------------------- fs/ubifs/auth.c | 25 +++++------- include/linux/key.h | 45 +++++++++++++++++++++- security/keys/key.c | 40 ++++++++++++++++++- 5 files changed, 107 insertions(+), 70 deletions(-) base-commit: 2734d6c1b1a089fb593ef6a23d4b70903526fe0c -- git-series 0.9.1