Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp397325pxv; Thu, 22 Jul 2021 03:00:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJI/aUE7boSbJW5n3DhuPnjGkwh/AjZFqg+1sHN/8aBnygyhAcoYEyXUMThAz3rWl4V2hn X-Received: by 2002:a05:6602:3155:: with SMTP id m21mr29857888ioy.145.1626948015040; Thu, 22 Jul 2021 03:00:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626948015; cv=none; d=google.com; s=arc-20160816; b=Nf5vAqazDMxdD4XqBzcz9fklWNGwLhEwHHONTS0WkxTgyNHgLD1khdgwNGM2bS/mI1 kq1G6dxJhtrPQ36zi+3qSVz9PaUWX326r0taQKrg9pTXQpVdeCSUckcKaKG/fw/Nw13/ Me/r9k8ljwgKFDxAuyLJqeJADfmeAD0pN+nTMVWX6RsuuzdjIrwXHH5jSKg8/NOagnD8 /TEdxP+jIgeKTR6Cz7hvGxRt68aQ8pBXWueitpt7mt6OmZBGCTpuxLkWbuL4wMI7ErMI mpCJaqUzjb/2ofH7Ybs5Ug5MTBUTkarBWrCufrpP5IvwKlTYe7WGjJLJi4SQHaZ5x55y aNDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=AZzdfaE2Wj3OTCZOBNEXdVIgOX2K8VJfAK/cviJItsg=; b=E5cS+cDqD+kRyebPKuCsxKp7md1UKKAT93CqFYT8LjOHghRH1+o/koPtRa96idlxtM ezoiIiUmV6VTeBjNOxiI2+IT7lQK/p6JxnBv0Bq1Vb5Msmcd0lQYNwVQzOZZnRT3dtHH T+w+JBLWDpxX6P6N0NvKfTc0mXXnronUxv1cmJGAlwGn4+rjub954ih2TaefWzE8dOeP z54LZ/GaqhFPyl97o5ngoMIhPUX6Uwbh8ciHsBjQUsMQ8X59/XQknJTO94b9TgYpP1Qj ZqYiGhdDqy84dudy6Jkw3A6TRruEfVd6lSbYPya04i9W9yvNoAadUifdx0/CdG3xE+gl McVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x1si30850749jan.58.2021.07.22.03.00.03; Thu, 22 Jul 2021 03:00:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231387AbhGVJRy (ORCPT + 99 others); Thu, 22 Jul 2021 05:17:54 -0400 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:44919 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231282AbhGVJRy (ORCPT ); Thu, 22 Jul 2021 05:17:54 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R851e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UgbPx.s_1626947902; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UgbPx.s_1626947902) by smtp.aliyun-inc.com(127.0.0.1); Thu, 22 Jul 2021 17:58:27 +0800 From: Jiapeng Chong To: saeedm@nvidia.com Cc: leon@kernel.org, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH v2] net/mlx5: Fix missing return value in mlx5_devlink_eswitch_inline_mode_set() Date: Thu, 22 Jul 2021 17:58:16 +0800 Message-Id: <1626947897-73558-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The return value is missing in this code scenario, add the return value '0' to the return value 'err'. Eliminate the follow smatch warning: drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:3083 mlx5_devlink_eswitch_inline_mode_set() warn: missing error code 'err'. Reported-by: Abaci Robot Fixes: 8e0aa4bc959c ("net/mlx5: E-switch, Protect eswitch mode changes") Signed-off-by: Jiapeng Chong --- Changes in v2: -For the follow advice: https://lore.kernel.org/patchwork/patch/1461601/ drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c index 7579f34..6b0b629 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c @@ -3079,8 +3079,11 @@ int mlx5_devlink_eswitch_inline_mode_set(struct devlink *devlink, u8 mode, switch (MLX5_CAP_ETH(dev, wqe_inline_mode)) { case MLX5_CAP_INLINE_MODE_NOT_REQUIRED: - if (mode == DEVLINK_ESWITCH_INLINE_MODE_NONE) + if (mode == DEVLINK_ESWITCH_INLINE_MODE_NONE) { + err = 0; goto out; + } + fallthrough; case MLX5_CAP_INLINE_MODE_L2: NL_SET_ERR_MSG_MOD(extack, "Inline mode can't be set"); -- 1.8.3.1