Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] checkpatch: add grammatical judgement for total output
To:     Joe Perches <joe@perches.com>, apw@canonical.com
Cc:     dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
        linux-kernel@vger.kernel.org
References: <20210721151416.30530-1-src.res@email.cn>
 <68b4f05607e9e44559e174d9b50e435fb58ef5aa.camel@perches.com>
From:   Hu Haowen <src.res@email.cn>
Message-ID: <1e0a9acb-e973-7371-8425-05e066db0827@email.cn>
Date:   Thu, 22 Jul 2021 18:04:45 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <68b4f05607e9e44559e174d9b50e435fb58ef5aa.camel@perches.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 2021/7/22 上午12:03, Joe Perches wrote:
> On Wed, 2021-07-21 at 23:14 +0800, Hu Haowen wrote:
>> There lacked a English grammatical identification within the final
>> output of checkpatch.pl such as the following:
>>
>>     total: 1 errors, 11 warnings, 4094 lines checked
>>                   ^
>>
>> Which violated the rule about the usage of the singular form and the
>> plural form. Hence fix the issue up and make it output the proper
>> sentence.
> NAK
>
> I appreciate the desire for precision but I don't want to require
> any automated downstream user of checkpatch to be changed.
>
> I think users understand the output even though it may not be
> grammatically correct in some cases.


How about another modification, which turns "errors" into "error(s)"?
In this case not only did the meaning convey but automated users won't
be confused toward their automatic programs.


>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>> @@ -7439,9 +7439,14 @@ sub process {
>>  	print report_dump();
>>  	if ($summary && !($clean == 1 && $quiet == 1)) {
>>  		print "$filename " if ($summary_file);
>> -		print "total: $cnt_error errors, $cnt_warn warnings, " .
>> -			(($check)? "$cnt_chk checks, " : "") .
>> -			"$cnt_lines lines checked\n";
>> +		my $errors_str = ($cnt_error == 1) ? "error" : "errors";
>> +		my $warnings_str = ($cnt_warn == 1) ? "warning" : "warnings";
>> +		my $checks_str = ($cnt_chk == 1) ? "check" : "checks";
>> +		my $lines_str = ($cnt_lines == 1) ? "line" : "lines";
>> +		print "total: $cnt_error $errors_str, " .
>> +			"$cnt_warn $warnings_str, " .
>> +			(($check)? "$cnt_chk $checks_str, " : "") .
>> +			"$cnt_lines $lines_str checked\n";
>>  	}
>>  
>>
>>  	if ($quiet == 0) {