Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 22 Jul 2021 12:19:40 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     "Jin, Yao" <yao.jin@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v3 3/3] perf tools: Enable on a list of CPUs for hybrid
Message-ID: <YPlGPC3OkPihS91A@krava>
References: <20210712071235.28533-1-yao.jin@linux.intel.com>
 <20210712071235.28533-4-yao.jin@linux.intel.com>
 <YPXUMTFbj2Tl3eBz@krava>
 <ecf0e815-616f-0a08-cefd-baac93c0e47d@linux.intel.com>
 <YPaUc3iodIASdYRY@krava>
 <598463ae-0bb0-7609-407b-4822112b2093@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <598463ae-0bb0-7609-407b-4822112b2093@linux.intel.com>
Precedence: bulk

On Wed, Jul 21, 2021 at 12:30:11PM +0800, Jin, Yao wrote:
> Hi Jiri,
> 
> On 7/20/2021 5:16 PM, Jiri Olsa wrote:
> > On Tue, Jul 20, 2021 at 03:07:02PM +0800, Jin, Yao wrote:
> > 
> > SNIP
> > 
> > > 
> > > OK, evlist__fix_cpus() is better, use this name in v4.
> > > 
> > > > > +{
> > > > > +	struct perf_cpu_map *cpus;
> > > > > +	struct evsel *evsel, *tmp;
> > > > > +	struct perf_pmu *pmu;
> > > > > +	int ret, unmatched_count = 0, events_nr = 0;
> > > > > +
> > > > > +	if (!perf_pmu__has_hybrid() || !cpu_list)
> > > > > +		return 0;
> > > > > +
> > > > > +	cpus = perf_cpu_map__new(cpu_list);
> > > > > +	if (!cpus)
> > > > > +		return -1;
> > > > > +
> > > > > +	evlist__for_each_entry_safe(evlist, tmp, evsel) {
> > > > > +		struct perf_cpu_map *matched_cpus, *unmatched_cpus;
> > > > > +		char buf1[128], buf2[128];
> > > > > +
> > > > > +		pmu = perf_pmu__find_hybrid_pmu(evsel->pmu_name);
> > > > > +		if (!pmu)
> > > > > +			continue;
> > > > > +
> > > > > +		ret = perf_pmu__cpus_match(pmu, cpus, &matched_cpus,
> > > > > +					   &unmatched_cpus);
> > > > > +		if (ret)
> > > > > +			goto out;
> > > > > +
> > > > > +		events_nr++;
> > > > > +
> > > > > +		if (matched_cpus->nr > 0 && (unmatched_cpus->nr > 0 ||
> > > > > +		    matched_cpus->nr < cpus->nr ||
> > > > > +		    matched_cpus->nr < pmu->cpus->nr)) {
> > > > > +			perf_cpu_map__put(evsel->core.cpus);
> > > > > +			perf_cpu_map__put(evsel->core.own_cpus);
> > > > > +			evsel->core.cpus = perf_cpu_map__get(matched_cpus);
> > > > > +			evsel->core.own_cpus = perf_cpu_map__get(matched_cpus);
> > > > 
> > > > I'm bit confused in here.. AFAIUI there's 2 evsel objects create
> > > > for hybrid 'cycles' ... should they have already proper cpus set?
> > > > 
> > > 
> > > For 'cycles', yes two evsels are created automatically. One is for atom CPU
> > > (e.g. 8-11), the other is for core CPU (e.g. 0-7). In this example, these 2
> > > evsels have already the cpus set.
> > 
> > hum, so those evsels are created with pmu's cpus, right?
> > 
> 
> Yes, that's right. But we also check and adjust the evsel->cpus by using
> user's cpu list on hybrid (what the evlist__use_cpu_list() does).
> 
> > > 
> > > While the 'cpus' here is just the user specified cpu list.
> > > cpus = perf_cpu_map__new(cpu_list);
> > 
> > then I think they will be changed by evlist__create_maps
> > with whatever user wants?
> > 
> 
> No, it will not be changed by evlist__create_maps.
> 
> In evlist__create_maps(),
> evlist->core.has_user_cpus = !!target->cpu_list && !target->hybrid;
> 
> It disables has_user_cpus for hybrid.
> 
> So in __perf_evlist__propagate_maps, they will not be changed by evlist->cpus.
> 
> if (!evsel->own_cpus || evlist->has_user_cpus) {
> 	perf_cpu_map__put(evsel->cpus);
> 	evsel->cpus = perf_cpu_map__get(evlist->cpus);
> 	
> > could we just change __perf_evlist__propagate_maps to follow
> > pmu's cpus?
> > 
> 
> In __perf_evlist__propagate_maps, it has already followed pmu's cpus because
> the evlist->has_user_cpus is false for hybrid.

sorry for delay

ok, so we first fix the cpus on hybrid events and then
propagate maps.. I guess it's ok, because it's in libperf
and that has no notion of hybrid so far

could you please rename that function so it's also obvious
it's for hybrid only

  evlist__fix_hybrid_cpus ? not sure ;-)

and add some comment with example to explain what the
function is doing

thanks,
jirka